[Fix] CommonHttpsClient Builder - set timeout correctly (#362)

## Changes
The issue was that `makeRequestConfig` was using `timeout` before it was
initialized, I have refactored the code to both fix and make it more
error proof in the future

## Tests
Not possible to write UT for this as its too encapsulated, will need
major refactors to be able to test via UT

Co-authored-by: hectorcast-db <[email protected]>

Author: satviksr-db

databricks-sdk-java/src/main/java/com/databricks/sdk/core/commons/CommonsHttpClient.java

@@ -104,11 +104,8 @@ public CommonsHttpClient build() {
 
   private static final Logger LOG = LoggerFactory.getLogger(CommonsHttpClient.class);
   private final CloseableHttpClient hc;
-  private int timeout;
 
   private CommonsHttpClient(Builder builder) {
-    HttpClientBuilder httpClientBuilder =
-        HttpClientBuilder.create().setDefaultRequestConfig(makeRequestConfig());
     int timeoutSeconds = 300;
     if (builder.databricksConfig != null
         && builder.databricksConfig.getHttpTimeoutSeconds() != null) {
@@ -117,7 +114,9 @@ private CommonsHttpClient(Builder builder) {
     if (builder.timeoutSeconds != null) {
       timeoutSeconds = builder.timeoutSeconds;
     }
-    timeout = timeoutSeconds * 1000;
+    int timeout = timeoutSeconds * 1000;
+    HttpClientBuilder httpClientBuilder =
+        HttpClientBuilder.create().setDefaultRequestConfig(makeRequestConfig(timeout));
     if (builder.proxyConfig != null) {
       ProxyUtils.setupProxy(builder.proxyConfig, httpClientBuilder);
     }
@@ -135,7 +134,7 @@ private CommonsHttpClient(Builder builder) {
     hc = httpClientBuilder.build();
   }
 
-  private RequestConfig makeRequestConfig() {
+  private RequestConfig makeRequestConfig(int timeout) {
     return RequestConfig.custom()
         .setConnectionRequestTimeout(timeout)
         .setConnectTimeout(timeout)