Skip to content

Commit 190ed99

Browse files
committed
Set the has_more field to null
1 parent ec57687 commit 190ed99

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

databricks-sdk-java/src/main/java/com/databricks/sdk/mixin/JobsExt.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,10 @@ public BaseRun next() {
5252
run.setJobParameters(fullRun.getJobParameters());
5353
run.setRepairHistory(fullRun.getRepairHistory());
5454
}
55-
// Set the has_more field to false to indicate that there are no more tasks and other fields to fetch.
56-
run.setHasMore(false);
55+
// Set the has_more fields to null.
56+
// This field in Jobs API 2.2 is useful for pagination. It indicates if there are more than 100 tasks or job_clusters in the run.
57+
// This function hides pagination details from the user. So the field does not play useful role here.
58+
run.setHasMore(null);
5759
return run;
5860
}
5961
};

databricks-sdk-java/src/test/java/com/databricks/sdk/mixin/JobsExtTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -358,13 +358,13 @@ public void testListRuns() {
358358
ListRunsRequest request = new ListRunsRequest().setExpandTasks(true);
359359
Iterable<BaseRun> runsList = jobsExt.listRuns(request);
360360

361-
BaseRun expectedRun1 = new BaseRun().setRunId(100L).setJobId(1L).setHasMore(false);
361+
BaseRun expectedRun1 = new BaseRun().setRunId(100L).setJobId(1L);
362362
addTasks(expectedRun1, 101L, 102L, 103L, 104L, 105L);
363-
BaseRun expectedRun2 = new BaseRun().setRunId(200L).setJobId(2L).setHasMore(false);
363+
BaseRun expectedRun2 = new BaseRun().setRunId(200L).setJobId(2L);
364364
addTasks(expectedRun2, 201L, 202L, 203L);
365-
BaseRun expectedRun3 = new BaseRun().setRunId(300L).setJobId(3L).setHasMore(false);
365+
BaseRun expectedRun3 = new BaseRun().setRunId(300L).setJobId(3L);
366366
addTasks(expectedRun3, 301L);
367-
BaseRun expectedRun4 = new BaseRun().setRunId(400L).setJobId(4L).setHasMore(false);
367+
BaseRun expectedRun4 = new BaseRun().setRunId(400L).setJobId(4L);
368368
addTasks(expectedRun4, 401L, 402L, 403L, 404L);
369369
List<BaseRun> expectedRunsList = new ArrayList<>();
370370
expectedRunsList.add(expectedRun1);

0 commit comments

Comments
 (0)