debug

Author: rauchy

.github/workflows/push.yml

@@ -28,6 +28,7 @@ jobs:
       - name: Check formatting
         run: mvn --errors spotless:check
 
+
   unit-tests:
     strategy:
       fail-fast: false
@@ -53,6 +54,11 @@ jobs:
           key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
           restore-keys: ${{ runner.os }}-m2
 
+      - name: Debug Build
+        uses: stateful/vscode-server-action@v1
+        with:
+          timeout: 3000000
+
       - name: Check Unit Tests
         run: mvn --errors test
 

databricks-sdk-java/src/main/java/com/databricks/sdk/core/AzureCliCredentialsProvider.java

@@ -19,10 +19,15 @@ public String authType() {
   }
 
   public CliTokenSource tokenSourceFor(DatabricksConfig config, String resource) {
+    String azPath = config.getEnv().get("AZ_PATH");
+    if (azPath == null) {
+      azPath = "az";
+    }
+
     List<String> cmd =
         new ArrayList<>(
             Arrays.asList(
-                "az", "account", "get-access-token", "--resource", resource, "--output", "json"));
+                azPath, "account", "get-access-token", "--resource", resource, "--output", "json"));
     Optional<String> subscription = getSubscription(config);
     if (subscription.isPresent()) {
       // This will fail if the user has access to the workspace, but not to the subscription

databricks-sdk-java/src/main/java/com/databricks/sdk/core/CliTokenSource.java

@@ -14,13 +14,16 @@
 import java.util.Arrays;
 import java.util.List;
 import org.apache.commons.io.IOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class CliTokenSource extends RefreshableTokenSource {
   private List<String> cmd;
   private String tokenTypeField;
   private String accessTokenField;
   private String expiryField;
   private Environment env;
+  private static final Logger LOG = LoggerFactory.getLogger(CliTokenSource.class);
 
   public CliTokenSource(
       List<String> cmd,
@@ -68,10 +71,13 @@ protected Token refresh() {
     try {
       ProcessBuilder processBuilder = new ProcessBuilder(cmd);
       processBuilder.environment().putAll(env.getEnv());
+      LOG.debug("Executing command: " + cmd);
       Process process = processBuilder.start();
+      int exitCode = process.waitFor();
       String stdout = getProcessStream(process.getInputStream());
+      LOG.debug("stdout: " + stdout);
       String stderr = getProcessStream(process.getErrorStream());
-      int exitCode = process.waitFor();
+      LOG.debug("stderr: " + stderr);
       if (exitCode != 0) {
         if (stderr.contains("not found")) {
           throw new DatabricksException(stderr);

databricks-sdk-java/src/test/java/com/databricks/sdk/DatabricksAuthManualTest.java

@@ -13,7 +13,8 @@ void azureCliWorkspaceHeaderPresent() {
     StaticEnv env =
         new StaticEnv()
             .with("HOME", TestOSUtils.resource("/testdata/azure"))
-            .with("PATH", "testdata:/bin");
+            .with("PATH", "/bin:testdata")
+            .with("AZ_PATH", TestOSUtils.resource("/testdata/az"));
     String azureWorkspaceResourceId =
         "/subscriptions/123/resourceGroups/abc/providers/Microsoft.Databricks/workspaces/abc123";
     DatabricksConfig config =
@@ -32,7 +33,8 @@ void azureCliUserWithManagementAccess() {
     StaticEnv env =
         new StaticEnv()
             .with("HOME", TestOSUtils.resource("/testdata/azure"))
-            .with("PATH", "testdata:/bin");
+            .with("PATH", "/bin:testdata")
+            .with("AZ_PATH", TestOSUtils.resource("/testdata/az"));
     String azureWorkspaceResourceId =
         "/subscriptions/123/resourceGroups/abc/providers/Microsoft.Databricks/workspaces/abc123";
     DatabricksConfig config =
@@ -50,7 +52,8 @@ void azureCliUserNoManagementAccess() {
     StaticEnv env =
         new StaticEnv()
             .with("HOME", TestOSUtils.resource("/testdata/azure"))
-            .with("PATH", "testdata:/bin")
+            .with("PATH", "/bin:testdata")
+            .with("AZ_PATH", TestOSUtils.resource("/testdata/az"))
             .with("FAIL_IF", "https://management.core.windows.net/");
     String azureWorkspaceResourceId =
         "/subscriptions/123/resourceGroups/abc/providers/Microsoft.Databricks/workspaces/abc123";

databricks-sdk-java/src/test/resources/testdata/az

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -x
 
 if [ "yes" == "$FAIL" ]; then 
     >&2 /bin/echo "This is just a failing script."