Skip to content

Commit ffc5f25

Browse files
authored
Fix release automation (#127)
## Changes I think there are two small bugs in the configuration of the release deployment in our github action: 1. the environment variable name is incorrect: it should be OSSRH_USERNAME/OSSRH_PASSWORD instead of MAVEN_USERNAME/MAVEN_PASSWORD. 2. action-gh-release should attach these resources to the existing release that will be created by our release automation tooling. This will not be a draft release, so I'll remove that flag. ## Tests <!-- How is this tested? -->
1 parent d46a9f5 commit ffc5f25

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@ jobs:
2525
run: mvn -Prelease -DskipTests=true --batch-mode deploy
2626
env:
2727
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
28-
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
29-
MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
28+
OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
29+
OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
3030

3131
- name: Create GitHub release
3232
uses: softprops/action-gh-release@v1
3333
with:
34-
draft: true
35-
files: target/*.jar
34+
files: target/*.jar

0 commit comments

Comments
 (0)