fix file reopen in tests

Author: yuanjieding-db

tests/test_files.py

@@ -224,30 +224,38 @@ def run(self, config: Config, monkeypatch) -> None:
                     response = w.files.download("/test").contents
                     response.read()
         elif self.download_mode == DownloadMode.FILE:  # FILE mode
-            with NamedTemporaryFile(delete=True) as temp_file:
+            with NamedTemporaryFile(delete=False) as temp_file:
+                file_path = temp_file.name
+
+            # We can't use 'with' because Windows doesn't allow reopening the file, and `download_to` can open it
+            # only after we close it here.
+            try:
                 if self.expected_exception is None:
                     w.files.download_to(
                         "/test",
-                        temp_file.name,
+                        file_path,
                         overwrite=self.overwrite,
                         use_parallel=self.use_parallel,
                         parallelism=self.parallelism,
                     )
 
                     # Verify the downloaded file content
-                    with open(temp_file.name, "rb") as f:
+                    with open(file_path, "rb") as f:
                         actual_content = f.read()
                     assert len(actual_content) == len(session.content)
                     assert actual_content == session.content
                 else:
                     with pytest.raises(self.expected_exception):
                         w.files.download_to(
                             "/test",
-                            temp_file.name,
+                            file_path,
                             overwrite=self.overwrite,
                             use_parallel=self.use_parallel,
                             parallelism=self.parallelism,
                         )
+            finally:
+                if os.path.exists(file_path):
+                    os.remove(file_path)
 
         received_requests = session.received_requests
 
@@ -972,30 +980,38 @@ def custom_matcher(request: requests.Request) -> Optional[requests.Response]:
                     if self.expected_download_api is not None:
                         assert state.api_used == self.expected_download_api
             elif download_mode == DownloadMode.FILE:
-                with NamedTemporaryFile(delete=True) as temp_file:
+                with NamedTemporaryFile(delete=False) as temp_file:
+                    file_path = temp_file.name
+
+                # We can't use 'with' because Windows doesn't allow reopening the file, and `download_to` can open it
+                # only after we close it here.
+                try:
                     if self.expected_exception_type is not None:
                         with pytest.raises(self.expected_exception_type):
                             w.files.download_to(
                                 PresignedUrlDownloadTestCase._FILE_PATH,
-                                temp_file.name,
+                                file_path,
                                 overwrite=self.overwrite,
                                 use_parallel=use_parallel,
                                 parallelism=self.parallelism,
                             )
                     else:
                         w.files.download_to(
                             PresignedUrlDownloadTestCase._FILE_PATH,
-                            temp_file.name,
+                            file_path,
                             overwrite=self.overwrite,
                             use_parallel=use_parallel,
                             parallelism=self.parallelism,
                         )
-                        with open(temp_file.name, "rb") as f:
+                        with open(file_path, "rb") as f:
                             actual_content = f.read()
                         assert len(actual_content) == len(state.content)
                         assert actual_content == state.content
                         if self.expected_download_api is not None:
                             assert state.api_used == self.expected_download_api
+                finally:
+                    if os.path.exists(file_path):
+                        os.remove(file_path)
             else:
                 raise ValueError("Unexpected download mode")