Skip to content

Commit 61a41fc

Browse files
[Internal] Add DCO guidelines (#773)
## Changes This PR updates the contributing guidelines to include the DCO (Developer Certificate of Origin) that external contributors must sign-off to contribute. ## Tests N/A
1 parent e23b4ac commit 61a41fc

File tree

2 files changed

+37
-44
lines changed

2 files changed

+37
-44
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -18,54 +18,22 @@ Code style is enforced by a formatter check in your pull request. We use [yapf](
1818
## Signed Commits
1919
This repo requires all contributors to sign their commits. To configure this, you can follow [Github's documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) to create a GPG key, upload it to your Github account, and configure your git client to sign commits.
2020

21-
## Sign your work
22-
The sign-off is a simple line at the end of the explanation for the patch. Your signature certifies that you wrote the patch or otherwise have the right to pass it on as an open-source patch. The rules are pretty simple: if you can certify the below (from developercertificate.org):
21+
## Developer Certificate of Origin
2322

24-
```
25-
Developer Certificate of Origin
26-
Version 1.1
27-
28-
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
29-
1 Letterman Drive
30-
Suite D4700
31-
San Francisco, CA, 94129
32-
33-
Everyone is permitted to copy and distribute verbatim copies of this
34-
license document, but changing it is not allowed.
35-
36-
37-
Developer's Certificate of Origin 1.1
38-
39-
By making a contribution to this project, I certify that:
40-
41-
(a) The contribution was created in whole or in part by me and I
42-
have the right to submit it under the open source license
43-
indicated in the file; or
23+
To contribute to this repository, you must sign off your commits to certify
24+
that you have the right to contribute the code and that it complies with the
25+
open source license. The rules are pretty simple, if you can certify the
26+
content of [DCO](./DCO), then simply add a "Signed-off-by" line to your
27+
commit message to certify your compliance. Please use your real name as
28+
pseudonymous/anonymous contributions are not accepted.
4429

45-
(b) The contribution is based upon previous work that, to the best
46-
of my knowledge, is covered under an appropriate open source
47-
license and I have the right under that license to submit that
48-
work with modifications, whether created in whole or in part
49-
by me, under the same open source license (unless I am
50-
permitted to submit under a different license), as indicated
51-
in the file; or
52-
53-
(c) The contribution was provided directly to me by some other
54-
person who certified (a), (b) or (c) and I have not modified
55-
it.
56-
57-
(d) I understand and agree that this project and the contribution
58-
are public and that a record of the contribution (including all
59-
personal information I submit with it, including my sign-off) is
60-
maintained indefinitely and may be redistributed consistent with
61-
this project or the open source license(s) involved.
30+
```
31+
Signed-off-by: Joe Smith <[email protected]>
6232
```
6333

64-
Then you just add a line to every git commit message:
34+
If you set your `user.name` and `user.email` git configs, you can sign your
35+
commit automatically with `git commit -s`:
6536

6637
```
67-
Signed-off-by: Joe Smith <[email protected]>
38+
git commit -s -m "Your commit message"
6839
```
69-
70-
If you set your `user.name` and `user.email` git configs, you can sign your commit automatically with git commit -s.
71-
You must use your real name (sorry, no pseudonyms or anonymous contributions).

DCO

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
Developer's Certificate of Origin 1.1
2+
3+
By making a contribution to this project, I certify that:
4+
5+
(a) The contribution was created in whole or in part by me and I
6+
have the right to submit it under the open source license
7+
indicated in the file; or
8+
9+
(b) The contribution is based upon previous work that, to the best
10+
of my knowledge, is covered under an appropriate open source
11+
license and I have the right under that license to submit that
12+
work with modifications, whether created in whole or in part
13+
by me, under the same open source license (unless I am
14+
permitted to submit under a different license), as indicated
15+
in the file; or
16+
17+
(c) The contribution was provided directly to me by some other
18+
person who certified (a), (b) or (c) and I have not modified
19+
it.
20+
21+
(d) I understand and agree that this project and the contribution
22+
are public and that a record of the contribution (including all
23+
personal information I submit with it, including my sign-off) is
24+
maintained indefinitely and may be redistributed consistent with
25+
this project or the open source license(s) involved.

0 commit comments

Comments
 (0)