improved naming convention and removed redundant code

Author: Divyansh-db

databricks/sdk/credentials_provider.py

@@ -89,7 +89,6 @@ def inner(
         @functools.wraps(func)
         def wrapper(cfg: "Config") -> Optional[CredentialsProvider]:
             for attr in require:
-                getattr(cfg, attr)
                 if not getattr(cfg, attr):
                     return None
             return func(cfg)
@@ -1054,11 +1053,11 @@ def model_serving_auth(cfg: "Config") -> Optional[CredentialsProvider]:
 
 
 class DefaultCredentials:
-    """Select the first applicable credential provider from the chain"""
+    """Select the first applicable credential strategy from the chain"""
 
     def __init__(self) -> None:
         self._auth_type = "default"
-        self._auth_providers = [
+        self._auth_strategies = [
             pat_auth,
             basic_auth,
             metadata_service,
@@ -1082,26 +1081,26 @@ def auth_type(self) -> str:
         return self._auth_type
 
     def oauth_token(self, cfg: "Config") -> oauth.Token:
-        for provider in self._auth_providers:
-            auth_type = provider.auth_type()
+        for strategy in self._auth_strategies:
+            auth_type = strategy.auth_type()
             if auth_type != self._auth_type:
                 # ignore other auth types if they don't match the selected one
                 continue
-            return provider.oauth_token(cfg)
+            return strategy.oauth_token(cfg)
 
     def __call__(self, cfg: "Config") -> CredentialsProvider:
-        for provider in self._auth_providers:
-            auth_type = provider.auth_type()
+        for strategy in self._auth_strategies:
+            auth_type = strategy.auth_type()
             if cfg.auth_type and auth_type != cfg.auth_type:
                 # ignore other auth types if one is explicitly enforced
                 logger.debug(f"Ignoring {auth_type} auth, because {cfg.auth_type} is preferred")
                 continue
             logger.debug(f"Attempting to configure auth: {auth_type}")
             try:
-                # The header factory might be None if the provider cannot be
+                # The header factory might be None if the strategy cannot be
                 # configured for the current environment. For example, if the
-                # provider requires some missing environment variables.
-                header_factory = provider(cfg)
+                # strategy requires some missing environment variables.
+                header_factory = strategy(cfg)
                 if not header_factory:
                     continue