Address review comments

Author: renaudhartert-db

tests/test_base_client.py

@@ -345,7 +345,7 @@ def inner(h: BaseHTTPRequestHandler):
         assert requests[0] == b"test data"
 
 
-def test_perform_resets_seekable_stream_on_error():
+def test_perform_resets_seekable_stream_on_retry():
     received_data = []
 
     # Always respond with a response that triggers a retry.
@@ -360,14 +360,14 @@ def inner(h: BaseHTTPRequestHandler):
 
     stream = io.BytesIO(b"0123456789") # seekable stream
 
+    # Read some data from the stream first to verify that the stream is
+    # reset to the correct position rather than to its beginning.
+    stream.read(4)
+    assert stream.tell() == 4
+
     with http_fixture_server(inner) as host:
         client = _BaseClient()
 
-        # Read some data from the stream first to verify that the stream is
-        # reset to the correct position rather than to its beginning.
-        stream.read(4)
-        assert stream.tell() == 4
-
         # Should fail but reset the stream.
         with pytest.raises(DatabricksError):
             client._perform('POST', f'{host}/foo', data=stream)
@@ -378,7 +378,7 @@ def inner(h: BaseHTTPRequestHandler):
         assert stream.tell() == 4
 
 
-def test_perform_does_not_reset_nonseekable_stream_on_error():
+def test_perform_does_not_reset_nonseekable_stream_on_retry():
     received_data = []
 
     # Always respond with a response that triggers a retry.
@@ -394,14 +394,14 @@ def inner(h: BaseHTTPRequestHandler):
     stream = io.BytesIO(b"0123456789")
     stream.seekable = lambda: False # makes the stream appear non-seekable
 
+    # Read some data from the stream first to verify that the stream is
+    # reset to the correct position rather than to its beginning.
+    stream.read(4)
+    assert stream.tell() == 4
+
     with http_fixture_server(inner) as host:
         client = _BaseClient()
 
-        # Read some data from the stream first to verify that the stream is
-        # reset to the correct position rather than to its beginning.
-        stream.read(4)
-        assert stream.tell() == 4
-
         # Should fail without resetting the stream.
         with pytest.raises(DatabricksError):
             client._perform('POST', f'{host}/foo', data=stream)