Skip to content

Add headers to HttpRequestResponse in OpenAI client. #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Add headers to HttpRequestResponse in OpenAI client. #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Release v0.60.0

### New Features and Improvements
* Added headers to HttpRequestResponse in OpenAI client.

### Bug Fixes

Expand Down
35 changes: 28 additions & 7 deletions databricks/sdk/mixins/open_ai_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from requests import Response

from databricks.sdk.service.serving import (ExternalFunctionRequestHttpMethod,
HttpRequestResponse,
ServingEndpointsAPI)


Expand Down Expand Up @@ -88,15 +89,30 @@ def http_request(
"""
response = Response()
response.status_code = 200
server_response = super().http_request(
connection_name=conn,
method=method,
path=path,
headers=js.dumps(headers) if headers is not None else None,
json=js.dumps(json) if json is not None else None,
params=js.dumps(params) if params is not None else None,

# We currently don't call super.http_request because we need to pass in response_headers
# This is a temporary fix to get the headers we need for the MCP session id
# TODO: Remove this once we have a better way to get back the response headers
headers_to_capture = ["mcp-session-id"]
res = self._api.do(
"POST",
"/api/2.0/external-function",
body={
"connection_name": conn,
"method": method.value,
"path": path,
"headers": js.dumps(headers) if headers is not None else None,
"json": js.dumps(json) if json is not None else None,
"params": js.dumps(params) if params is not None else None,
},
headers={"Accept": "text/plain", "Content-Type": "application/json"},
raw=True,
response_headers=headers_to_capture,
Comment on lines +97 to +110
Copy link
Contributor

@renaudhartert-db renaudhartert-db Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectorcast-db, can you think of something better given the current libraries? Not using the underlying API method is really not ideal but I can't think of a better alternative with the code that we have right now.

)

# Create HttpRequestResponse from the raw response
server_response = HttpRequestResponse.from_dict(res)

# Read the content from the HttpRequestResponse object
if hasattr(server_response, "contents") and hasattr(server_response.contents, "read"):
raw_content = server_response.contents.read() # Read the bytes
Expand All @@ -109,4 +125,9 @@ def http_request(
else:
raise ValueError("Contents must be bytes.")

# Copy headers from raw response to Response
for header_name in headers_to_capture:
if header_name in res:
response.headers[header_name] = res[header_name]

return response
Loading