-
Notifications
You must be signed in to change notification settings - Fork 178
Add FieldMask class and helper functions #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3871a28 to
2588545
Compare
Divyansh-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Can you also get an approval from Parth or Omer
096bc3e to
14d55e3
Compare
parthban-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo nit.
4813d7b to
13fb116
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
What changes are proposed in this pull request?
Add FieldMask class and helper functions.
This class methods have the same signature than the google.protobuf.FieldMask
https://github.com/protocolbuffers/protobuf/blob/main/python/google/protobuf/internal/field_mask.py#L18
but serialize the FieldMask using snake_case, as expected by Databricks server.
Helper functions are required because serialization framework in templates only supports single line code.
Version Pin
Why >=4.21.0:
Stability: Version 4.21.0 was a stable release that introduced important performance improvements and API stabilization
Python 3.7+ compatibility.
Why <7.0:
Major version boundary: Avoid future breaking changes.
How is this tested?
Added unit tests.
NO_CHANGELOG=true