Skip to content

[Internal] Make model serving unit tests a little more hermetic #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

[Internal] Make model serving unit tests a little more hermetic #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a1975
Isolate test
renaudhartert-db Feb 28, 2025
2c62fdb
Remove details
renaudhartert-db Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion databricks/sdk/errors/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@


class ErrorDetail:

def __init__(
self,
type: str = None,
Expand Down
8 changes: 7 additions & 1 deletion tests/test_model_serving_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,12 @@ def test_model_serving_auth_refresh(monkeypatch, mocker):


def test_agent_user_credentials(monkeypatch, mocker):
# Guarantee that the tests defaults to env variables rather than config file.
#
# TODO: this is hacky and we should find a better way to tell the config
# that it should not read from the config file.
monkeypatch.setenv("DATABRICKS_CONFIG_FILE", "x")

monkeypatch.setenv("IS_IN_DB_MODEL_SERVING_ENV", "true")
monkeypatch.setenv("DB_MODEL_SERVING_HOST_URL", "x")
monkeypatch.setattr(
Expand Down Expand Up @@ -205,4 +211,4 @@ def test_agent_user_credentials_in_non_model_serving_environments(monkeypatch):
headers = cfg.authenticate()

assert cfg.host == "https://x"
assert headers.get("Authorization") == f"Bearer token"
assert headers.get("Authorization") == "Bearer token"
Loading