Skip to content

[Internal] Fix test_access_control_list to use correct JobAccessControlRequest type #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

[Internal] Fix test_access_control_list to use correct JobAccessControlRequest type #942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d7588
Fix test
parthban-db Mar 31, 2025
3751810
update
parthban-db Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
DatabricksEnvironment)
from databricks.sdk.databricks.oauth import Token
from databricks.sdk.service.catalog import PermissionsChange
from databricks.sdk.service.iam import AccessControlRequest
from databricks.sdk.service.jobs import JobAccessControlRequest
from databricks.sdk.version import __version__

from .conftest import noop_credentials
Expand Down Expand Up @@ -287,9 +287,8 @@ def test_access_control_list(config, requests_mock):
"http://localhost/api/2.2/jobs/create",
request_headers={"User-Agent": config.user_agent},
)

w = WorkspaceClient(config=config)
res = w.jobs.create(access_control_list=[AccessControlRequest(group_name="group")])
res = w.jobs.create(access_control_list=[JobAccessControlRequest(group_name="group")])

assert requests_mock.call_count == 1
assert requests_mock.called
Expand Down
Loading