Skip to content

Conversation

@mgyucht
Copy link
Contributor

@mgyucht mgyucht commented May 2, 2025

What changes are proposed in this pull request?

A regression was introduced in v0.51 of the Python SDK affecting the query_index() method of the VectorSearchAPI, causing the query result to be dropped during deserialization. This PR fixes this by correcting the deserialization logic and the type of the API response.

How is this tested?

This matches the implementation from the last working version v0.50.

@mgyucht mgyucht temporarily deployed to test-trigger-is May 2, 2025 15:47 — with GitHub Actions Inactive
@mgyucht mgyucht temporarily deployed to test-trigger-is May 2, 2025 15:48 — with GitHub Actions Inactive
@mgyucht mgyucht enabled auto-merge May 2, 2025 15:48
Signed-off-by: Miles Yucht <[email protected]>
@mgyucht mgyucht temporarily deployed to test-trigger-is May 2, 2025 16:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented May 2, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 961
  • Commit SHA: a24da49ddcbdacde5c2352823100bb7be1001d91

Checks will be approved automatically on success.

@mgyucht mgyucht temporarily deployed to test-trigger-is May 2, 2025 16:06 — with GitHub Actions Inactive
@mgyucht mgyucht added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit 1be6359 May 2, 2025
17 checks passed
@mgyucht mgyucht deleted the feat/fix-vector-search branch May 2, 2025 16:40
deco-sdk-tagging bot added a commit that referenced this pull request May 2, 2025
## Release v0.53.0

### Bug Fixes
* Fixed the deserialization of responses in VectorSearchAPI's `query_index()` method ([#961](#961)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants