Skip to content

Commit ad8bb37

Browse files
[PECO-1356] Removed protocol check in GO (#185)
Customers have reached out in Node and GO about protocol versioning not being correctly reflected by the server. We've decided to revert these changes in Node, this PR does the same for GO.
2 parents 1f7f71d + 1648935 commit ad8bb37

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

connection.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,6 @@ func (c *conn) ExecContext(ctx context.Context, query string, args []driver.Name
112112
defer log.Duration(msg, start)
113113

114114
corrId := driverctx.CorrelationIdFromContext(ctx)
115-
if len(args) > 0 && c.session.ServerProtocolVersion < cli_service.TProtocolVersion_SPARK_CLI_SERVICE_PROTOCOL_V8 {
116-
return nil, dbsqlerrint.NewDriverError(ctx, dbsqlerr.ErrParametersNotSupported, nil)
117-
}
118115

119116
exStmtResp, opStatusResp, err := c.runQuery(ctx, query, args)
120117
log, ctx = client.LoggerAndContext(ctx, exStmtResp)
@@ -159,10 +156,6 @@ func (c *conn) QueryContext(ctx context.Context, query string, args []driver.Nam
159156
log, _ := client.LoggerAndContext(ctx, nil)
160157
msg, start := log.Track("QueryContext")
161158

162-
if len(args) > 0 && c.session.ServerProtocolVersion < cli_service.TProtocolVersion_SPARK_CLI_SERVICE_PROTOCOL_V8 {
163-
return nil, dbsqlerrint.NewDriverError(ctx, dbsqlerr.ErrParametersNotSupported, nil)
164-
}
165-
166159
// first we try to get the results synchronously.
167160
// at any point in time that the context is done we must cancel and return
168161
exStmtResp, opStatusResp, err := c.runQuery(ctx, query, args)

0 commit comments

Comments
 (0)