Convert unit tests to Typescript (#258)

* Convert unit tests to Typescript

Signed-off-by: Levko Kravets <[email protected]>

* Polish & cleanup

Signed-off-by: Levko Kravets <[email protected]>

* Polish & cleanup

Signed-off-by: Levko Kravets <[email protected]>

---------

Signed-off-by: Levko Kravets <[email protected]>

Author: kravets-levko

lib/DBSQLClient.ts

@@ -7,6 +7,7 @@ import { TProtocolVersion } from '../thrift/TCLIService_types';
 import IDBSQLClient, { ClientOptions, ConnectionOptions, OpenSessionRequest } from './contracts/IDBSQLClient';
 import IDriver from './contracts/IDriver';
 import IClientContext, { ClientConfig } from './contracts/IClientContext';
+import IThriftClient from './contracts/IThriftClient';
 import HiveDriver from './hive/HiveDriver';
 import DBSQLSession from './DBSQLSession';
 import IDBSQLSession from './contracts/IDBSQLSession';
@@ -43,6 +44,8 @@ function getInitialNamespaceOptions(catalogName?: string, schemaName?: string) {
   };
 }
 
+export type ThriftLibrary = Pick<typeof thrift, 'createClient'>;
+
 export default class DBSQLClient extends EventEmitter implements IDBSQLClient, IClientContext {
   private static defaultLogger?: IDBSQLLogger;
 
@@ -52,17 +55,17 @@ export default class DBSQLClient extends EventEmitter implements IDBSQLClient, I
 
   private authProvider?: IAuthentication;
 
-  private client?: TCLIService.Client;
+  private client?: IThriftClient;
 
   private readonly driver = new HiveDriver({
     context: this,
   });
 
   private readonly logger: IDBSQLLogger;
 
-  private readonly thrift = thrift;
+  private thrift: ThriftLibrary = thrift;
 
-  private sessions = new CloseableCollection<DBSQLSession>();
+  private readonly sessions = new CloseableCollection<DBSQLSession>();
 
   private static getDefaultLogger(): IDBSQLLogger {
     if (!this.defaultLogger) {
@@ -113,7 +116,7 @@ export default class DBSQLClient extends EventEmitter implements IDBSQLClient, I
     };
   }
 
-  private initAuthProvider(options: ConnectionOptions, authProvider?: IAuthentication): IAuthentication {
+  private createAuthProvider(options: ConnectionOptions, authProvider?: IAuthentication): IAuthentication {
     if (authProvider) {
       return authProvider;
     }
@@ -143,6 +146,10 @@ export default class DBSQLClient extends EventEmitter implements IDBSQLClient, I
     }
   }
 
+  private createConnectionProvider(options: ConnectionOptions): IConnectionProvider {
+    return new HttpConnection(this.getConnectionOptions(options), this);
+  }
+
   /**
    * Connects DBSQLClient to endpoint
    * @public
@@ -153,9 +160,9 @@ export default class DBSQLClient extends EventEmitter implements IDBSQLClient, I
    * const session = client.connect({host, path, token});
    */
   public async connect(options: ConnectionOptions, authProvider?: IAuthentication): Promise<IDBSQLClient> {
-    this.authProvider = this.initAuthProvider(options, authProvider);
+    this.authProvider = this.createAuthProvider(options, authProvider);
 
-    this.connectionProvider = new HttpConnection(this.getConnectionOptions(options), this);
+    this.connectionProvider = this.createConnectionProvider(options);
 
     const thriftConnection = await this.connectionProvider.getThriftConnection();
 
@@ -238,7 +245,7 @@ export default class DBSQLClient extends EventEmitter implements IDBSQLClient, I
     return this.connectionProvider;
   }
 
-  public async getClient(): Promise<TCLIService.Client> {
+  public async getClient(): Promise<IThriftClient> {
     const connectionProvider = await this.getConnectionProvider();
 
     if (!this.client) {

lib/DBSQLOperation.ts

@@ -64,7 +64,7 @@ export default class DBSQLOperation implements IOperation {
 
   private metadata?: TGetResultSetMetadataResp;
 
-  private state: number = TOperationState.INITIALIZED_STATE;
+  private state: TOperationState = TOperationState.INITIALIZED_STATE;
 
   // Once operation is finished or fails - cache status response, because subsequent calls
   // to `getOperationStatus()` may fail with irrelevant errors, e.g. HTTP 404

lib/connection/auth/DatabricksOAuth/AuthorizationCode.ts

@@ -6,50 +6,19 @@ import { OAuthScopes, scopeDelimiter } from './OAuthScope';
 import IClientContext from '../../../contracts/IClientContext';
 import AuthenticationError from '../../../errors/AuthenticationError';
 
+export type DefaultOpenAuthUrlCallback = (authUrl: string) => Promise<void>;
+
+export type OpenAuthUrlCallback = (authUrl: string, defaultOpenAuthUrl: DefaultOpenAuthUrlCallback) => Promise<void>;
+
 export interface AuthorizationCodeOptions {
   client: BaseClient;
   ports: Array<number>;
   context: IClientContext;
+  openAuthUrl?: OpenAuthUrlCallback;
 }
 
-async function startServer(
-  host: string,
-  port: number,
-  requestHandler: (req: IncomingMessage, res: ServerResponse) => void,
-): Promise<Server> {
-  const server = http.createServer(requestHandler);
-
-  return new Promise((resolve, reject) => {
-    const errorListener = (error: Error) => {
-      server.off('error', errorListener);
-      reject(error);
-    };
-
-    server.on('error', errorListener);
-    server.listen(port, host, () => {
-      server.off('error', errorListener);
-      resolve(server);
-    });
-  });
-}
-
-async function stopServer(server: Server): Promise<void> {
-  if (!server.listening) {
-    return;
-  }
-
-  return new Promise((resolve, reject) => {
-    const errorListener = (error: Error) => {
-      server.off('error', errorListener);
-      reject(error);
-    };
-
-    server.on('error', errorListener);
-    server.close(() => {
-      server.off('error', errorListener);
-      resolve();
-    });
-  });
+async function defaultOpenAuthUrl(authUrl: string): Promise<void> {
+  await open(authUrl);
 }
 
 export interface AuthorizationCodeFetchResult {
@@ -65,16 +34,12 @@ export default class AuthorizationCode {
 
   private readonly host: string = 'localhost';
 
-  private readonly ports: Array<number>;
+  private readonly options: AuthorizationCodeOptions;
 
   constructor(options: AuthorizationCodeOptions) {
     this.client = options.client;
-    this.ports = options.ports;
     this.context = options.context;
-  }
-
-  private async openUrl(url: string) {
-    return open(url);
+    this.options = options;
   }
 
   public async fetch(scopes: OAuthScopes): Promise<AuthorizationCodeFetchResult> {
@@ -84,7 +49,7 @@ export default class AuthorizationCode {
 
     let receivedParams: CallbackParamsType | undefined;
 
-    const server = await this.startServer((req, res) => {
+    const server = await this.createServer((req, res) => {
       const params = this.client.callbackParams(req);
       if (params.state === state) {
         receivedParams = params;
@@ -108,7 +73,8 @@ export default class AuthorizationCode {
       redirect_uri: redirectUri,
     });
 
-    await this.openUrl(authUrl);
+    const openAuthUrl = this.options.openAuthUrl ?? defaultOpenAuthUrl;
+    await openAuthUrl(authUrl, defaultOpenAuthUrl);
     await server.stopped();
 
     if (!receivedParams || !receivedParams.code) {
@@ -122,11 +88,11 @@ export default class AuthorizationCode {
     return { code: receivedParams.code, verifier: verifierString, redirectUri };
   }
 
-  private async startServer(requestHandler: (req: IncomingMessage, res: ServerResponse) => void) {
-    for (const port of this.ports) {
+  private async createServer(requestHandler: (req: IncomingMessage, res: ServerResponse) => void) {
+    for (const port of this.options.ports) {
       const host = this.host; // eslint-disable-line prefer-destructuring
       try {
-        const server = await startServer(host, port, requestHandler); // eslint-disable-line no-await-in-loop
+        const server = await this.startServer(host, port, requestHandler); // eslint-disable-line no-await-in-loop
         this.context.getLogger().log(LogLevel.info, `Listening for OAuth authorization callback at ${host}:${port}`);
 
         let resolveStopped: () => void;
@@ -140,7 +106,7 @@ export default class AuthorizationCode {
           host,
           port,
           server,
-          stop: () => stopServer(server).then(resolveStopped).catch(rejectStopped),
+          stop: () => this.stopServer(server).then(resolveStopped).catch(rejectStopped),
           stopped: () => stoppedPromise,
         };
       } catch (error) {
@@ -156,6 +122,50 @@ export default class AuthorizationCode {
     throw new AuthenticationError('Failed to start server: all ports are in use');
   }
 
+  private createHttpServer(requestHandler: (req: IncomingMessage, res: ServerResponse) => void) {
+    return http.createServer(requestHandler);
+  }
+
+  private async startServer(
+    host: string,
+    port: number,
+    requestHandler: (req: IncomingMessage, res: ServerResponse) => void,
+  ): Promise<Server> {
+    const server = this.createHttpServer(requestHandler);
+
+    return new Promise((resolve, reject) => {
+      const errorListener = (error: Error) => {
+        server.off('error', errorListener);
+        reject(error);
+      };
+
+      server.on('error', errorListener);
+      server.listen(port, host, () => {
+        server.off('error', errorListener);
+        resolve(server);
+      });
+    });
+  }
+
+  private async stopServer(server: Server): Promise<void> {
+    if (!server.listening) {
+      return;
+    }
+
+    return new Promise((resolve, reject) => {
+      const errorListener = (error: Error) => {
+        server.off('error', errorListener);
+        reject(error);
+      };
+
+      server.on('error', errorListener);
+      server.close(() => {
+        server.off('error', errorListener);
+        resolve();
+      });
+    });
+  }
+
   private renderCallbackResponse(): string {
     const applicationName = 'Databricks Sql Connector';
 

lib/connection/auth/DatabricksOAuth/index.ts

@@ -7,7 +7,7 @@ import IClientContext from '../../../contracts/IClientContext';
 
 export { OAuthFlow };
 
-interface DatabricksOAuthOptions extends OAuthManagerOptions {
+export interface DatabricksOAuthOptions extends OAuthManagerOptions {
   scopes?: OAuthScopes;
   persistence?: OAuthPersistence;
   headers?: HeadersInit;
@@ -18,14 +18,13 @@ export default class DatabricksOAuth implements IAuthentication {
 
   private readonly options: DatabricksOAuthOptions;
 
-  private readonly manager: OAuthManager;
+  private manager?: OAuthManager;
 
   private readonly defaultPersistence = new OAuthPersistenceCache();
 
   constructor(options: DatabricksOAuthOptions) {
     this.context = options.context;
     this.options = options;
-    this.manager = OAuthManager.getManager(this.options);
   }
 
   public async authenticate(): Promise<HeadersInit> {
@@ -35,15 +34,22 @@ export default class DatabricksOAuth implements IAuthentication {
 
     let token = await persistence.read(host);
     if (!token) {
-      token = await this.manager.getToken(scopes ?? defaultOAuthScopes);
+      token = await this.getManager().getToken(scopes ?? defaultOAuthScopes);
     }
 
-    token = await this.manager.refreshAccessToken(token);
+    token = await this.getManager().refreshAccessToken(token);
     await persistence.persist(host, token);
 
     return {
       ...headers,
       Authorization: `Bearer ${token.accessToken}`,
     };
   }
+
+  private getManager(): OAuthManager {
+    if (!this.manager) {
+      this.manager = OAuthManager.getManager(this.options);
+    }
+    return this.manager;
+  }
 }

lib/connection/connections/HttpConnection.ts

@@ -36,7 +36,7 @@ export default class HttpConnection implements IConnectionProvider {
     });
   }
 
-  public async getAgent(): Promise<http.Agent> {
+  public async getAgent(): Promise<http.Agent | undefined> {
     if (!this.agent) {
       if (this.options.proxy !== undefined) {
         this.agent = this.createProxyAgent(this.options.proxy);

lib/connection/connections/HttpRetryPolicy.ts

@@ -12,7 +12,7 @@ function delay(milliseconds: number): Promise<void> {
 export default class HttpRetryPolicy implements IRetryPolicy<HttpTransactionDetails> {
   private context: IClientContext;
 
-  private readonly startTime: number; // in milliseconds
+  private startTime: number; // in milliseconds
 
   private attempt: number;
 

lib/connection/contracts/IConnectionProvider.ts

@@ -10,7 +10,7 @@ export interface HttpTransactionDetails {
 export default interface IConnectionProvider {
   getThriftConnection(): Promise<any>;
 
-  getAgent(): Promise<http.Agent>;
+  getAgent(): Promise<http.Agent | undefined>;
 
   setHeaders(headers: HeadersInit): void;
 

lib/contracts/IClientContext.ts

@@ -1,7 +1,7 @@
 import IDBSQLLogger from './IDBSQLLogger';
 import IDriver from './IDriver';
 import IConnectionProvider from '../connection/contracts/IConnectionProvider';
-import TCLIService from '../../thrift/TCLIService';
+import IThriftClient from './IThriftClient';
 
 export interface ClientConfig {
   directResultsDefaultMaxRows: number;
@@ -29,7 +29,7 @@ export default interface IClientContext {
 
   getConnectionProvider(): Promise<IConnectionProvider>;
 
-  getClient(): Promise<TCLIService.Client>;
+  getClient(): Promise<IThriftClient>;
 
   getDriver(): Promise<IDriver>;
 }

lib/contracts/IThriftClient.ts

@@ -0,0 +1,9 @@
+import TCLIService from '../../thrift/TCLIService';
+
+type ThriftClient = TCLIService.Client;
+
+type ThriftClientMethods = {
+  [K in keyof ThriftClient]: ThriftClient[K];
+};
+
+export default interface IThriftClient extends ThriftClientMethods {}

lib/hive/Commands/BaseCommand.ts

@@ -1,15 +1,14 @@
 import { Response } from 'node-fetch';
-import TCLIService from '../../../thrift/TCLIService';
 import HiveDriverError from '../../errors/HiveDriverError';
 import RetryError, { RetryErrorCode } from '../../errors/RetryError';
 import IClientContext from '../../contracts/IClientContext';
 
-export default abstract class BaseCommand {
-  protected client: TCLIService.Client;
+export default abstract class BaseCommand<ClientType> {
+  protected client: ClientType;
 
   protected context: IClientContext;
 
-  constructor(client: TCLIService.Client, context: IClientContext) {
+  constructor(client: ClientType, context: IClientContext) {
     this.client = client;
     this.context = context;
   }