Skip to content

Commit 1965df5

Browse files
sebbeggJesse Whitehouse
andauthored
Fix proxy connection pool creation (#158)
Signed-off-by: Sebastian Eckweiler <[email protected]> Signed-off-by: Jesse Whitehouse <[email protected]> Co-authored-by: Sebastian Eckweiler <[email protected]> Co-authored-by: Jesse Whitehouse <[email protected]>
1 parent 7382631 commit 1965df5

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- Add support for Cloud Fetch
66
- Fix: Revised SQLAlchemy dialect and examples for compatibility with SQLAlchemy==1.3.x
77
- Fix: oauth would fail if expired credentials appeared in ~/.netrc
8+
- Fix: Python HTTP proxies were broken after switch to urllib3
89

910
## 2.7.0 (2023-06-26)
1011

src/databricks/sql/auth/thrift_http_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,10 @@ def open(self):
109109
headers={"Proxy-Authorization": self.proxy_auth},
110110
)
111111
self.__pool = proxy_manager.connection_from_host(
112-
self.host, self.port, pool_kwargs=_pool_kwargs
112+
host=self.realhost,
113+
port=self.realport,
114+
scheme=self.scheme,
115+
pool_kwargs=_pool_kwargs,
113116
)
114117
else:
115118
self.__pool = pool_class(self.host, self.port, **_pool_kwargs)

0 commit comments

Comments
 (0)