Skip to content

Commit 2f54be8

Browse files
committed
lint issue fixing
Signed-off-by: Nikhil Suri <[email protected]>
1 parent ef41f4c commit 2f54be8

File tree

3 files changed

+6
-33
lines changed

3 files changed

+6
-33
lines changed

src/databricks/sql/client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,11 @@ def read(self) -> Optional[OAuthToken]:
326326
# Determine proxy usage
327327
use_proxy = self.http_client.using_proxy()
328328
proxy_host_info = None
329-
if use_proxy and self.http_client.proxy_uri and isinstance(self.http_client.proxy_uri, str):
329+
if (
330+
use_proxy
331+
and self.http_client.proxy_uri
332+
and isinstance(self.http_client.proxy_uri, str)
333+
):
330334
parsed = urlparse(self.http_client.proxy_uri)
331335
proxy_host_info = HostDetails(
332336
host_url=parsed.hostname or self.http_client.proxy_uri,

src/databricks/sql/common/unified_http_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def __init__(self, client_context):
5050
"""
5151
self.config = client_context
5252
# Since the unified http client is used for all requests, we need to have proxy and direct pool managers
53-
# for per-reques ̰ˇt proxy decisions.
53+
# for per-request proxy decisions.
5454
self._direct_pool_manager = None
5555
self._proxy_pool_manager = None
5656
self._retry_policy = None

src/databricks/sql/telemetry/models/event.py

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,6 @@ class ChunkDetails(JsonSerializableMixin):
155155
Contains detailed metrics about chunk downloads during result fetching.
156156
157157
These metrics are accumulated across all chunk downloads for a single statement.
158-
In Java, this is populated by the StatementTelemetryDetails tracker as chunks are downloaded.
159-
160-
Tracking approach:
161-
- Initialize total_chunks_present from result manifest
162-
- For each chunk downloaded:
163-
* Increment total_chunks_iterated
164-
* Add chunk latency to sum_chunks_download_time_millis
165-
* Update initial_chunk_latency_millis (first chunk only)
166-
* Update slowest_chunk_latency_millis (if current chunk is slower)
167158
168159
Attributes:
169160
initial_chunk_latency_millis (int): Latency of the first chunk download
@@ -197,11 +188,6 @@ class ResultLatency(JsonSerializableMixin):
197188
result_set_ready_latency_millis (int): Time until query results are ready (execution phase)
198189
result_set_consumption_latency_millis (int): Time spent fetching/consuming results (fetch phase)
199190
200-
Note:
201-
Java implementation includes private field 'startTimeOfResultSetIterationNano' for internal
202-
tracking (not serialized to JSON). When implementing tracking in Python, use similar approach:
203-
- Record start time on first fetchone/fetchmany/fetchall call
204-
- Calculate total consumption latency when iteration completes or cursor closes
205191
"""
206192

207193
result_set_ready_latency_millis: Optional[int] = None
@@ -213,23 +199,6 @@ class OperationDetail(JsonSerializableMixin):
213199
"""
214200
Contains detailed information about the operation being performed.
215201
216-
This provides more granular operation tracking than statement_type, allowing
217-
differentiation between similar operations (e.g., EXECUTE_STATEMENT vs EXECUTE_STATEMENT_ASYNC).
218-
219-
Tracking approach:
220-
- operation_type: Map method name to operation type enum
221-
* Java maps: executeStatement -> EXECUTE_STATEMENT
222-
* Java maps: listTables -> LIST_TABLES
223-
* Python could use similar mapping from method names
224-
225-
- is_internal_call: Track if operation is initiated by driver internally
226-
* Set to true for driver-initiated metadata calls
227-
* Set to false for user-initiated operations
228-
229-
- Status polling: For async operations
230-
* Increment n_operation_status_calls for each status check
231-
* Accumulate operation_status_latency_millis across all status calls
232-
233202
Attributes:
234203
n_operation_status_calls (int): Number of status polling calls made
235204
operation_status_latency_millis (int): Total latency of all status calls

0 commit comments

Comments
 (0)