SQLAlchemy 2: Finish marking all tests in the suite (#253)

Signed-off-by: Jesse Whitehouse <[email protected]>

Author: Jesse

src/databricks/sqlalchemy/__init__.py

@@ -1 +1 @@
-from databricks.sqlalchemy.base import DatabricksDialect
+from databricks.sqlalchemy.base import DatabricksDialect

src/databricks/sqlalchemy/base.py

@@ -45,7 +45,7 @@ class DatabricksImpl(DefaultImpl):
 class DatabricksDialect(default.DefaultDialect):
     """This dialect implements only those methods required to pass our e2e tests"""
 
-    # Possible attributes are defined here: https://docs.sqlalchemy.org/en/14/core/internals.html#sqlalchemy.engine.Dialect
+    # See sqlalchemy.engine.interfaces for descriptions of each of these properties
     name: str = "databricks"
     driver: str = "databricks"
     default_schema_name: str = "default"
@@ -60,6 +60,10 @@ class DatabricksDialect(default.DefaultDialect):
     supports_identity_columns: bool = True
     supports_schemas: bool = True
     paramstyle: str = "named"
+    div_is_floordiv: bool = False
+    supports_default_values: bool = False
+    supports_server_side_cursors: bool = False
+    supports_sequences: bool = False
 
     colspecs = {
         sqlalchemy.types.DateTime: dialect_type_impl.DatabricksDateTimeNoTimezoneType,
@@ -109,7 +113,18 @@ def get_columns(
             ).fetchall()
 
         if not resp:
-            raise sqlalchemy.exc.NoSuchTableError(table_name)
+            # TGetColumnsRequest will not raise an exception if passed a table that doesn't exist
+            # But Databricks supports tables with no columns. So if the result is an empty list,
+            # we need to check if the table exists (and raise an exception if not) or simply return
+            # an empty list.
+            self._describe_table_extended(
+                connection,
+                table_name,
+                self.catalog,
+                schema or self.schema,
+                expect_result=False,
+            )
+            return resp
         columns = []
         for col in resp:
             row_dict = parse_column_info_from_tgetcolumnsresponse(col)

src/databricks/sqlalchemy/requirements.py

@@ -158,7 +158,7 @@ def temporary_tables(self):
     def table_reflection(self):
         """target database has general support for table reflection"""
         return sqlalchemy.testing.exclusions.open()
-    
+
     @property
     def temp_table_reflection(self):
         """ComponentReflection test is intricate and simply cannot function without this exclusion being defined here.
@@ -181,9 +181,50 @@ def unique_constraint_reflection(self):
         Databricks doesn't support UNIQUE constraints.
         """
         return sqlalchemy.testing.exclusions.closed()
-    
+
     @property
     def reflects_pk_names(self):
         """Target driver reflects the name of primary key constraints."""
 
-        return sqlalchemy.testing.exclusions.open()
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def datetime_implicit_bound(self):
+        """target dialect when given a datetime object will bind it such
+        that the database server knows the object is a date, and not
+        a plain string.
+        """
+
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def tuple_in(self):
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def ctes(self):
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def ctes_with_update_delete(self):
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def delete_from(self):
+        """Target must support DELETE FROM..FROM or DELETE..USING syntax"""
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def table_value_constructor(self):
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def reflect_tables_no_columns(self):
+        return sqlalchemy.testing.exclusions.open()
+
+    @property
+    def denormalized_names(self):
+        """Target database must have 'denormalized', i.e.
+        UPPERCASE as case insensitive names."""
+
+        return sqlalchemy.testing.exclusions.open()