added more logs to identify server side flag evaluation

Signed-off-by: Nikhil Suri <[email protected]>

Author: nikhilsuri-db

src/databricks/sql/common/feature_flag.py

@@ -116,31 +116,37 @@ def _refresh_flags(self):
             self._connection.session.auth_provider.add_headers(headers)
             headers["User-Agent"] = self._connection.session.useragent_header
 
-            logger.info(f"Fetching feature flags from: {self._feature_flag_endpoint}")
+            logger.info(
+                f"Feature Flags: Sending GET request to endpoint: {self._feature_flag_endpoint}"
+            )
             response = self._http_client.request(
                 HttpMethod.GET, self._feature_flag_endpoint, headers=headers, timeout=30
             )
 
-            logger.info(f"Feature flag response status: {response.status}")
+            logger.info(f"Feature Flags: HTTP Response status code: {response.status}")
+
             if response.status == 200:
                 # Parse JSON response from urllib3 response data
                 response_data = json.loads(response.data.decode())
-                logger.info(f"Feature flag response data: {response_data}")
+                logger.info(
+                    f"Feature Flags: ✓ SUCCESS - Received {len(response_data.get('flags', []))} flags from server"
+                )
+                logger.info(f"Feature Flags: Response data: {response_data}")
                 ff_response = FeatureFlagsResponse.from_dict(response_data)
                 self._update_cache_from_response(ff_response)
-                logger.info(f"Feature flags loaded: {self._flags}")
+                logger.info(f"Feature Flags: Loaded into cache: {self._flags}")
             else:
                 # On failure, initialize with an empty dictionary to prevent re-blocking.
                 logger.info(
-                    f"Feature flag fetch failed with status {response.status}, initializing empty flags"
+                    f"Feature Flags: ✗ FAILED - Non-200 status code {response.status}, using empty flags"
                 )
                 if self._flags is None:
                     self._flags = {}
 
         except Exception as e:
             # On exception, initialize with an empty dictionary to prevent re-blocking.
             logger.info(
-                f"Feature flag fetch exception: {type(e).__name__}: {e}, initializing empty flags"
+                f"Feature Flags: ✗ EXCEPTION - {type(e).__name__}: {e}, using empty flags"
             )
             if self._flags is None:
                 self._flags = {}

src/databricks/sql/telemetry/telemetry_client.py

@@ -114,17 +114,42 @@ def is_telemetry_enabled(connection: "Connection") -> bool:
             return True
 
         if connection.enable_telemetry:
+            from databricks.sql import __version__
+
+            endpoint = f"https://{connection.session.host}/api/2.0/connector-service/feature-flags/PYTHON/{__version__}"
             logger.info(
-                f"Telemetry: enable_telemetry=True, checking feature flag: {TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME}"
+                f"Telemetry: enable_telemetry=True, checking server-side feature flag"
             )
-            context = FeatureFlagsContextFactory.get_instance(connection)
-            flag_value = context.get_flag_value(
-                TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
+            logger.info(f"Telemetry: Feature flag endpoint: {endpoint}")
+            logger.info(
+                f"Telemetry: Looking for flag: {TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME}"
             )
-            logger.info(f"Telemetry: feature flag value = '{flag_value}'")
-            enabled = str(flag_value).lower() == "true"
-            logger.info(f"Telemetry: feature flag check result = {enabled}")
-            return enabled
+
+            try:
+                context = FeatureFlagsContextFactory.get_instance(connection)
+                flag_value = context.get_flag_value(
+                    TelemetryHelper.TELEMETRY_FEATURE_FLAG_NAME, default_value=False
+                )
+                logger.info(
+                    f"Telemetry: Feature flag fetch SUCCESS - received value: '{flag_value}'"
+                )
+
+                enabled = str(flag_value).lower() == "true"
+                if enabled:
+                    logger.info(
+                        f"Telemetry: ✓ Server flag is 'true', telemetry ENABLED"
+                    )
+                else:
+                    logger.info(
+                        f"Telemetry: ✗ Server flag is '{flag_value}' (not 'true'), telemetry DISABLED"
+                    )
+                return enabled
+            except Exception as e:
+                logger.info(
+                    f"Telemetry: Feature flag fetch FAILED with exception: {type(e).__name__}: {e}"
+                )
+                logger.info("Telemetry: Defaulting to DISABLED due to fetch failure")
+                return False
         else:
             logger.info("Telemetry: enable_telemetry=False, telemetry DISABLED")
             return False