Skip to content

Commit c70f512

Browse files
committed
removed fetchall log assertion
Signed-off-by: Sai Shree Pradhan <[email protected]>
1 parent 1f13936 commit c70f512

File tree

2 files changed

+60
-228
lines changed

2 files changed

+60
-228
lines changed

tests/e2e/test_concurrent_telemetry.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,8 @@ def test_concurrent_queries_sends_telemetry(self):
4949
num_threads = 5
5050
captured_telemetry = []
5151
captured_telemetry_lock = threading.Lock()
52-
captured_responses = []
53-
captured_responses_lock = threading.Lock()
5452

5553
original_send_telemetry = TelemetryClient._send_telemetry
56-
original_callback = TelemetryClient._telemetry_request_callback
5754

5855
def send_telemetry_wrapper(self_client, events):
5956
with captured_telemetry_lock:
@@ -76,10 +73,10 @@ def execute_query_worker(thread_id):
7673
TelemetryClientFactory._executor.shutdown(wait=True)
7774

7875
# --- VERIFICATION ---
79-
assert len(captured_telemetry) == num_threads * 3 # 4 events per thread (initial_telemetry_log, 2 latency_logs (execute, fetchall))
76+
assert len(captured_telemetry) == num_threads * 2 # 2 events per thread (initial_telemetry_log, latency_log (execute))
8077

8178
events_with_latency = [
8279
e for e in captured_telemetry
8380
if e.entry.sql_driver_log.operation_latency_ms is not None and e.entry.sql_driver_log.sql_statement_id is not None
8481
]
85-
assert len(events_with_latency) == num_threads * 2 # 2 events per thread (execute, fetchall)
82+
assert len(events_with_latency) == num_threads # 1 event per thread (execute)

0 commit comments

Comments
 (0)