Skip to content

Commit e3b00e3

Browse files
ensure Dict return from _filter_session_conf
Signed-off-by: varun-edachali-dbx <[email protected]>
1 parent e09de76 commit e3b00e3

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/databricks/sql/backend/sea/backend.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@
4848

4949

5050
def _filter_session_configuration(
51-
session_configuration: Optional[Dict[str, Any]]
52-
) -> Optional[Dict[str, str]]:
51+
session_configuration: Optional[Dict[str, Any]],
52+
) -> Dict[str, str]:
5353
if not session_configuration:
54-
return None
54+
return {}
5555

5656
filtered_session_configuration = {}
5757
ignored_configs: Set[str] = set()

tests/unit/test_sea_backend.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ def test_utility_methods(self, sea_client):
621621
assert description[1][1] == "INT" # type_code
622622
assert description[1][6] is False # null_ok
623623

624-
def test_filter_session_configuration_string_values(self):
624+
def test_filter_session_configuration(self):
625625
"""Test that _filter_session_configuration converts all values to strings."""
626626
session_config = {
627627
"ANSI_MODE": True,
@@ -656,10 +656,7 @@ def test_filter_session_configuration_string_values(self):
656656
assert result == expected_result
657657

658658
# Test with None input
659-
assert _filter_session_configuration(None) is None
660-
661-
# Test with empty dict
662-
assert _filter_session_configuration({}) is None
659+
assert _filter_session_configuration(None) == {}
663660

664661
# Test with only unsupported parameters
665662
unsupported_config = {

0 commit comments

Comments
 (0)