Skip to content

Unity Catalog table double type erroneously read as float #18

@up-stevesloan

Description

@up-stevesloan

NOTE, this was discovered when used in conjunction with alembic. When an existing table has columns of type double, alembic generates these:

INFO  [alembic.autogenerate.compare] Detected type change from Float() to Double()

for each column in the existing table that is type double, and of course the unnecessary alter column commands in the resulting migration script.

Poking around in the dialect code, I believe the cause to be this line.

Since SQLAlchemy does have a Double type (sqlalchemy.types.Double), I think this would be a pretty easy PR, but wanted to check with the maintaners on this.

Thanks for your time and consideration!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions