Skip to content

Commit 0fa1396

Browse files
Fix the what's new popup so that it actually shows on a version update (#905)
## Changes ## Tests <!-- How is this tested? -->
1 parent 0cc9741 commit 0fa1396

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

packages/databricks-vscode/resources/whats-new/1.2.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<img src="../../images/databricks-logo.png" alt="databricks-logo" width="100"/>
1+
<img src="./1.2/databricks-logo.png" alt="databricks-logo" width="100"/>
22

33
# Databricks Extension v1.2.0
44

15.9 KB
Loading

packages/databricks-vscode/src/extension.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -558,14 +558,18 @@ export async function activate(
558558
);
559559
});
560560

561-
showWhatsNewPopup(context, stateStorage).catch((e) => {
562-
logging.NamedLogger.getOrCreate(Loggers.Extension).error(
563-
"Error while showing popup for what's new",
564-
e
565-
);
566-
});
561+
showWhatsNewPopup(context, stateStorage)
562+
.catch((e) => {
563+
logging.NamedLogger.getOrCreate(Loggers.Extension).error(
564+
"Error while showing popup for what's new",
565+
e
566+
);
567+
})
568+
.finally(() => {
569+
stateStorage.lastInstalledExtensionVersion =
570+
packageMetadata.version;
571+
});
567572

568-
stateStorage.lastInstalledExtensionVersion = packageMetadata.version;
569573
CustomWhenContext.setActivated(true);
570574
telemetry.recordEvent(Events.EXTENSION_ACTIVATED);
571575

0 commit comments

Comments
 (0)