Minor bug fixes (#412)

- Fix prompt for to show --allow-no-subscription when asking to change
tenant.
- Fix Repos bug where first time users of a workspace can't read
/Repos/me. Users need to go to the UI and create a repo for the
/Repos/me to be visible. After first creation, it is always visible. The
fix is to make users go to the workspace home when they click "Create
Repo".
- Fix a bug where to kill a full-sync task, the user had to kill the
terminal manually.
- Change autocompletion for globals prompt to allow for cases where
builtins is already installed.

Author: kartikgupta-db

packages/databricks-vscode/src/cli/BricksTasks.ts

@@ -18,10 +18,12 @@ import {withLogContext} from "@databricks/databricks-sdk/dist/logging";
 import {Loggers} from "../logger";
 import {Context, context} from "@databricks/databricks-sdk/dist/context";
 
-enum TaskSyncType {
-    syncFull = "sync-full",
-    sync = "sync",
-}
+export const TaskSyncType = {
+    syncFull: "sync-full",
+    sync: "sync",
+} as const;
+type TaskSyncType = (typeof TaskSyncType)[keyof typeof TaskSyncType];
+
 const cliToTaskSyncType = new Map<SyncType, TaskSyncType>([
     ["full", TaskSyncType.syncFull],
     ["incremental", TaskSyncType.sync],

packages/databricks-vscode/src/configuration/AzureCliCheck.ts

@@ -238,7 +238,7 @@ export class AzureCliCheck implements Disposable {
     public async loginAzureCli(tenant = ""): Promise<boolean> {
         let message = 'You need to run "az login" to login with Azure.';
         if (tenant) {
-            message = `You need to tun "az login -t ${tenant}" to login with Azure.`;
+            message = `You need to tun "az login --allow-no-subscriptions -t ${tenant}" to login with Azure.`;
         }
         const choice = await window.showInformationMessage(
             message,

packages/databricks-vscode/src/configuration/ConnectionCommands.ts

@@ -207,7 +207,7 @@ export class ConnectionCommands implements Disposable {
                 wsClient,
                 rootDirPath.path
             );
-            if (!rootDir) {
+            if (!rootDir && workspaceConfigs.enableFilesInWorkspace) {
                 const created = await (
                     await WorkspaceFsEntity.fromPath(wsClient, `/Users/${me}`)
                 )?.mkdir(rootDirPath.path);
@@ -268,7 +268,14 @@ export class ConnectionCommands implements Disposable {
                             return;
                         }
                         if (!workspaceConfigs.enableFilesInWorkspace) {
-                            UrlUtils.openExternal((await rootDir?.url) ?? "");
+                            UrlUtils.openExternal(
+                                (await rootDir?.url) ??
+                                    (
+                                        await this.connectionManager
+                                            .workspaceClient?.apiClient?.host
+                                    )?.href ??
+                                    ""
+                            );
                             return;
                         }
                         const created = await this.wsfsCommands.createFolder(

packages/databricks-vscode/src/language/ConfigureAutocomplete.ts

@@ -52,7 +52,7 @@ interface IPythonExtension {
 
 const importString = "from databricks.sdk.runtime import *";
 
-type StepResult = "Skip" | "Cancel" | "Error" | undefined;
+type StepResult = "Skip" | "Cancel" | "Error" | "Silent" | undefined;
 
 interface Step {
     fn: (dryRun: boolean) => Promise<StepResult>;
@@ -147,8 +147,7 @@ export class ConfigureAutocomplete implements Disposable {
                     ),
             },
             {
-                fn: async (dryRun = false) => this.updateExtraPaths(dryRun),
-                required: true,
+                fn: async () => this.updateExtraPaths(),
             },
             {
                 fn: async (dryRun = false) => this.addBuiltinsFile(dryRun),
@@ -162,8 +161,8 @@ export class ConfigureAutocomplete implements Disposable {
         }
 
         const choice = await window.showInformationMessage(
-            "To allow autocompletion for Databricks specific globals (like dbutils), we need to install pyspark and add (or modify) __builtins__.pyi file to your project",
-            "Continue",
+            "Do you want to configure autocompletion for Databricks specific globals (dbutils etc)?",
+            "Configure",
             "Cancel"
         );
 
@@ -219,7 +218,7 @@ export class ConfigureAutocomplete implements Disposable {
         terminal.show();
     }
 
-    private async updateExtraPaths(dryRun = false): Promise<StepResult> {
+    private async updateExtraPaths(): Promise<StepResult> {
         const extraPaths =
             workspace
                 .getConfiguration("python")
@@ -228,9 +227,6 @@ export class ConfigureAutocomplete implements Disposable {
             path.join("resources", "python", "stubs")
         );
         if (extraPaths.includes(stubPath)) {
-            return "Skip";
-        }
-        if (dryRun) {
             return;
         }
         extraPaths.push(stubPath);

packages/databricks-vscode/src/sync/CodeSynchronizer.ts

@@ -1,5 +1,5 @@
 import {Disposable, Event, EventEmitter, TaskExecution, tasks} from "vscode";
-import {SyncTask} from "../cli/BricksTasks";
+import {SyncTask, TaskSyncType} from "../cli/BricksTasks";
 import {CliWrapper} from "../cli/CliWrapper";
 import {ConnectionManager} from "../configuration/ConnectionManager";
 
@@ -36,14 +36,20 @@ export class CodeSynchronizer implements Disposable {
             }),
             tasks.onDidStartTask((e) => {
                 const {type, task} = e.execution.task.definition;
-                if (type === "databricks" && task === "sync") {
+                if (
+                    type === "databricks" &&
+                    Object.values(TaskSyncType).includes(task)
+                ) {
                     this.currentTaskExecution = e.execution;
                     this._onDidChangeStateEmitter.fire(this.state);
                 }
             }),
             tasks.onDidEndTask((e) => {
                 const {type, task} = e.execution.task.definition;
-                if (type === "databricks" && task === "sync") {
+                if (
+                    type === "databricks" &&
+                    Object.values(TaskSyncType).includes(task)
+                ) {
                     this.currentTaskExecution = undefined;
                     this._onDidChangeStateEmitter.fire(this.state);
                 }