Don't show start icon for terminating clusters (#338)

# Before change


https://user-images.githubusercontent.com/88345179/210543096-77f80d7a-62e2-48a4-a7b1-5d232b1b1101.mov

# After change



https://user-images.githubusercontent.com/88345179/210543123-e65dcb65-146a-4d0c-8529-f19e6b849b16.mov

Author: kartikgupta-db

packages/databricks-vscode/package.json

@@ -282,12 +282,12 @@
                 },
                 {
                     "command": "databricks.cluster.stop",
-                    "when": "view == configurationView && viewItem == clusterRunning || view == configurationView && viewItem == clusterPending",
+                    "when": "view == configurationView && viewItem =~ /^databricks.cluster.(running|pending)$/",
                     "group": "inline@0"
                 },
                 {
                     "command": "databricks.cluster.start",
-                    "when": "view == configurationView && viewItem == clusterStopped",
+                    "when": "view == configurationView && viewItem == databricks.cluster.terminated",
                     "group": "inline@0"
                 },
                 {

packages/databricks-vscode/src/cluster/ClusterListDataProvider.ts

@@ -3,6 +3,7 @@ import {
     Event,
     EventEmitter,
     ProviderResult,
+    ThemeColor,
     ThemeIcon,
     TreeDataProvider,
     TreeItem,
@@ -84,7 +85,10 @@ export class ClusterListDataProvider
                 break;
 
             case "TERMINATING":
-                icon = new ThemeIcon("stop-circle");
+                icon = new ThemeIcon(
+                    "stop-circle",
+                    new ThemeColor("notificationsErrorIcon.foreground")
+                );
                 break;
 
             case "TERMINATED":

packages/databricks-vscode/src/cluster/ClusterManager.ts

@@ -54,7 +54,6 @@ export class ClusterManager implements Disposable {
         this.cancellationTokenSource?.cancel();
         this.cancellationTokenSource = new CancellationTokenSource();
 
-        //TODO: add cancellation and onProgress cb after adding these to API generator
         await this.cluster.stop(
             this.cancellationTokenSource.token,
             async (clusterInfo: cluster.ClusterInfo) =>

packages/databricks-vscode/src/configuration/ConfigurationDataProvider.test.ts

@@ -132,7 +132,7 @@ describe(__filename, () => {
             },
             {
                 collapsibleState: 2,
-                contextValue: "clusterStopped",
+                contextValue: "databricks.cluster.terminated",
                 iconPath: {
                     color: undefined,
                     id: "server",

packages/databricks-vscode/src/configuration/ConfigurationDataProvider.ts

@@ -82,19 +82,36 @@ export class ConfigurationDataProvider
             });
 
             if (cluster) {
+                let contextValue:
+                    | "databricks.cluster.running"
+                    | "databricks.cluster.pending"
+                    | "databricks.cluster.terminating"
+                    | "databricks.cluster.terminated" =
+                    "databricks.cluster.terminated";
+
+                switch (cluster.state) {
+                    case "RUNNING":
+                        contextValue = "databricks.cluster.running";
+                        break;
+                    case "PENDING":
+                    case "RESIZING":
+                    case "RESTARTING":
+                        contextValue = "databricks.cluster.pending";
+                        break;
+                    case "TERMINATING":
+                        contextValue = "databricks.cluster.terminating";
+                        break;
+                    case "TERMINATED":
+                        contextValue = "databricks.cluster.terminated";
+                        break;
+                }
+
                 children.push({
                     label: "Cluster",
                     iconPath: new ThemeIcon("server"),
                     id: "CLUSTER",
                     collapsibleState: TreeItemCollapsibleState.Expanded,
-                    contextValue:
-                        cluster.state === "RUNNING"
-                            ? "clusterRunning"
-                            : ["PENDING", "RESIZING", "RESTARTING"].includes(
-                                  cluster.state
-                              )
-                            ? "clusterPending"
-                            : "clusterStopped",
+                    contextValue,
                 });
             } else {
                 children.push({