Improve run button UX (#1397)

## Changes
- Add login command to the run context menu if the extension is logged
out
- Focus config view when the login command is executed
- Fix a bug where the run button isn't visible if the vscode is opened
with a python file already active

<img width="570" alt="Screenshot 2024-10-18 at 11 13 24"
src="https://github.com/user-attachments/assets/a992c165-c849-4c67-8636-d3c28011d382">

 The Sign-In item is not visible in the logged in state

## Tests
Manually and existing tests

Author: ilia-db

packages/databricks-vscode/package.json

@@ -578,25 +578,30 @@
                 }
             ],
             "databricks.run": [
+                {
+                    "command": "databricks.connection.configureLogin",
+                    "when": "databricks.context.activated && !databricks.context.loggedIn",
+                    "group": "1_login@0"
+                },
                 {
                     "command": "databricks.run.runEditorContents",
-                    "when": "resourceLangId == python",
-                    "group": "1_remote@1"
+                    "when": "databricks.context.activated && resourceLangId == python",
+                    "group": "2_remote@1"
                 },
                 {
                     "command": "databricks.run.runEditorContentsAsWorkflow",
-                    "when": "resourceLangId == python || resourceExtname == .ipynb || databricks.context.showRunAsWorkflow",
-                    "group": "1_remote@2"
+                    "when": "databricks.context.activated && resourceLangId == python || resourceExtname == .ipynb || databricks.context.showRunAsWorkflow",
+                    "group": "2_remote@2"
                 },
                 {
                     "command": "databricks.run.dbconnect.debug",
-                    "when": "resourceLangId == python",
-                    "group": "2_local@1"
+                    "when": "databricks.context.activated && resourceLangId == python",
+                    "group": "3_local@1"
                 },
                 {
                     "command": "databricks.run.dbconnect.run",
-                    "when": "resourceLangId == python",
-                    "group": "2_local@2"
+                    "when": "databricks.context.activated && resourceLangId == python",
+                    "group": "3_local@2"
                 }
             ],
             "commandPalette": [

packages/databricks-vscode/src/configuration/ConnectionCommands.ts

@@ -5,6 +5,7 @@ import {
     QuickPickItemKind,
     ThemeIcon,
     window,
+    commands,
 } from "vscode";
 import {ClusterListDataProvider} from "../cluster/ClusterListDataProvider";
 import {ClusterModel} from "../cluster/ClusterModel";
@@ -73,6 +74,7 @@ export class ConnectionCommands implements Disposable {
     }
 
     async configureLoginCommand(arg?: {id: string}) {
+        commands.executeCommand("configurationView.focus");
         let source: ManualLoginSource = "command";
         if (arg?.id === AUTH_TYPE_SWITCH_ID) {
             source = "authTypeSwitch";

packages/databricks-vscode/src/configuration/ConnectionManager.ts

@@ -392,7 +392,7 @@ export class ConnectionManager implements Disposable {
     async configureLogin(source: ManualLoginSource) {
         if (this.configureLoginMutex.locked) {
             window.showErrorMessage(
-                "Databricks: Already configuring workspace"
+                "Databricks: sign in is already in progress"
             );
             return;
         }

packages/databricks-vscode/src/extension.ts

@@ -72,7 +72,6 @@ import {EnvironmentCommands} from "./language/EnvironmentCommands";
 import {WorkspaceFolderManager} from "./vscode-objs/WorkspaceFolderManager";
 import {SyncCommands} from "./sync/SyncCommands";
 import {CodeSynchronizer} from "./sync";
-import {LocalUri} from "./sync/SyncDestination";
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const packageJson = require("../package.json");
@@ -730,10 +729,11 @@ export async function activate(
 
     const runCommands = new RunCommands(
         connectionManager,
-        workspace.workspaceFolders[0],
+        workspaceFolderManager,
         pythonExtensionWrapper,
         featureManager,
-        context
+        context,
+        customWhenContext
     );
     const debugFactory = new DatabricksDebugAdapterFactory(
         connectionManager,
@@ -777,20 +777,6 @@ export async function activate(
             runCommands.runEditorContentsAsWorkflowCommand(),
             runCommands
         ),
-        window.onDidChangeActiveTextEditor(async (e) => {
-            const uri = e?.document.uri;
-
-            if (
-                uri &&
-                uri.scheme === "file" &&
-                ((await FileUtils.isNotebook(new LocalUri(uri))) ||
-                    uri.fsPath.endsWith(".py"))
-            ) {
-                customWhenContext.setShowRunAsWorkflow(true);
-            } else {
-                customWhenContext.setShowRunAsWorkflow(false);
-            }
-        }),
         debug.registerDebugAdapterDescriptorFactory("databricks", debugFactory),
         debugFactory,
         debug.registerDebugAdapterDescriptorFactory(

packages/databricks-vscode/src/run/RunCommands.ts

@@ -1,11 +1,4 @@
-import {
-    commands,
-    debug,
-    ExtensionContext,
-    Uri,
-    window,
-    WorkspaceFolder,
-} from "vscode";
+import {commands, debug, ExtensionContext, Uri, window} from "vscode";
 import {ConnectionManager} from "../configuration/ConnectionManager";
 import {FileUtils} from "../utils";
 import {LocalUri} from "../sync/SyncDestination";
@@ -17,18 +10,42 @@ import {
     escapeExecutableForTerminal,
     escapePathArgument,
 } from "../utils/shellUtils";
+import {CustomWhenContext} from "../vscode-objs/CustomWhenContext";
+import {WorkspaceFolderManager} from "../vscode-objs/WorkspaceFolderManager";
 
 /**
  * Run related commands
  */
 export class RunCommands {
     constructor(
         private connection: ConnectionManager,
-        private readonly workspaceFolder: WorkspaceFolder,
+        private readonly workspaceFolderManager: WorkspaceFolderManager,
         private readonly pythonExtension: MsPythonExtensionWrapper,
         private readonly featureManager: FeatureManager,
-        private readonly context: ExtensionContext
-    ) {}
+        private readonly context: ExtensionContext,
+        private readonly customWhenContext: CustomWhenContext
+    ) {
+        this.context.subscriptions.push(
+            window.onDidChangeActiveTextEditor(async () =>
+                this.updateRunAsWorkflowContext()
+            )
+        );
+        this.updateRunAsWorkflowContext();
+    }
+
+    async updateRunAsWorkflowContext() {
+        const uri = window.activeTextEditor?.document.uri;
+        if (
+            uri &&
+            uri.scheme === "file" &&
+            ((await FileUtils.isNotebook(new LocalUri(uri))) ||
+                uri.fsPath.endsWith(".py"))
+        ) {
+            this.customWhenContext.setShowRunAsWorkflow(true);
+        } else {
+            this.customWhenContext.setShowRunAsWorkflow(false);
+        }
+    }
 
     /**
      * Run a Python file using the command execution API
@@ -130,7 +147,10 @@ export class RunCommands {
             env: {...process.env},
         };
 
-        debug.startDebugging(this.workspaceFolder, config);
+        debug.startDebugging(
+            this.workspaceFolderManager.activeWorkspaceFolder,
+            config
+        );
     }
 
     async runFileUsingDbconnect(resource?: Uri) {