Improve parsing or error replies from command execution (#260)

Before:



https://user-images.githubusercontent.com/40952/204820495-cf5781ef-935b-41f9-9389-f64b3a73934c.mov

After:



https://user-images.githubusercontent.com/40952/204820534-b2077591-4943-40e9-93f5-7d50bcc33219.mov

Author: fjakobs

packages/databricks-vscode/src/configuration/SyncDestination.ts

@@ -110,4 +110,14 @@ export class SyncDestination {
         );
         return Uri.joinPath(this.repoPath, relativePath).path;
     }
+
+    remoteToLocal(remotePath: Uri): Uri {
+        assert.equal(remotePath.scheme, "wsfs");
+        if (!remotePath.path.startsWith(this.repoPath.path)) {
+            throw new Error("remote path is not within the target repo");
+        }
+
+        const relativePath = remotePath.path.replace(this.repoPath.path, "");
+        return Uri.joinPath(this.vscodeWorkspacePath, relativePath);
+    }
 }

packages/databricks-vscode/src/run/DatabricksDebugAdapter.ts

@@ -116,8 +116,8 @@ export class DatabricksDebugSession extends LoggingDebugSession {
                     }
 
                     body.source = this.createSource(filePath);
-                    body.line = this.convertDebuggerLineToClient(line);
-                    body.column = this.convertDebuggerColumnToClient(column);
+                    body.line = line;
+                    body.column = column;
 
                     this.sendEvent(e);
                 }

packages/databricks-vscode/src/run/DatabricksRuntime.test.ts

@@ -152,8 +152,7 @@ describe(__filename, () => {
 
         await runtime.start("/Desktop/workspaces/hello.py", [], {});
 
-        assert.equal(outputs.length, 7);
+        assert.equal(outputs.length, 6);
         assert.equal(outputs[4].text, "something went wrong");
-        assert.equal(outputs[5].text, "summary");
     });
 });

packages/databricks-vscode/src/run/DatabricksRuntime.ts

@@ -19,6 +19,8 @@ import {ConnectionManager} from "../configuration/ConnectionManager";
 import {promptForClusterStart} from "./prompts";
 import {CodeSynchronizer} from "../sync/CodeSynchronizer";
 import * as fs from "node:fs/promises";
+import {parseErrorResult} from "./ErrorParser";
+import path from "node:path";
 
 export interface OutputEvent {
     type: "prio" | "out" | "err";
@@ -175,20 +177,33 @@ export class DatabricksRuntime implements Disposable {
                     column: 0,
                 });
             } else if (result.results!.resultType === "error") {
-                this._onDidSendOutputEmitter.fire({
-                    type: "out",
-                    text: (result.results! as any).cause,
-                    filePath: program,
-                    line: 0,
-                    column: 0,
-                });
-                this._onDidSendOutputEmitter.fire({
-                    type: "out",
-                    text: (result.results! as any).summary,
-                    filePath: program,
-                    line: 0,
-                    column: 0,
-                });
+                const frames = parseErrorResult(result.results!);
+                for (const frame of frames) {
+                    let localFile = "";
+                    try {
+                        if (frame.file) {
+                            localFile = syncDestination.remoteToLocal(
+                                Uri.from({
+                                    scheme: "wsfs",
+                                    path: path.normalize(frame.file),
+                                })
+                            ).fsPath;
+
+                            frame.text = frame.text.replace(
+                                frame.file,
+                                localFile
+                            );
+                        }
+                    } catch (e) {}
+
+                    this._onDidSendOutputEmitter.fire({
+                        type: "out",
+                        text: frame.text,
+                        filePath: localFile,
+                        line: frame.line || 0,
+                        column: 0,
+                    });
+                }
             } else {
                 this._onDidSendOutputEmitter.fire({
                     type: "out",