Skip to content

Commit d9029b3

Browse files
committed
Revert "WIP: add serverless e2e tests"
This reverts commit 4a5db6c.
1 parent 4a5db6c commit d9029b3

File tree

4 files changed

+13
-85
lines changed

4 files changed

+13
-85
lines changed

packages/databricks-vscode/scripts/list_integration_tests.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const integrationTests = glob
2121
return {
2222
path: toUnixPath(path.relative(process.cwd(), testPath)),
2323
baseName: path.basename(testPath, ".e2e.ts"),
24-
serverless: testPath.includes("serverless") ? true : false,
2524
};
2625
});
2726

packages/databricks-vscode/src/test/e2e/run_files.serverless.e2e.ts

Lines changed: 0 additions & 56 deletions
This file was deleted.

packages/databricks-vscode/src/test/e2e/utils/dabsFixtures.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,10 @@ export function getBasicBundleConfig(
6060
topLevelComputeId = true
6161
): BundleSchema {
6262
assert(process.env.DATABRICKS_HOST, "DATABRICKS_HOST doesn't exist");
63-
if (!topLevelComputeId) {
64-
assert(
65-
process.env.TEST_DEFAULT_CLUSTER_ID,
66-
"TEST_DEFAULT_CLUSTER_ID doesn't exist"
67-
);
68-
}
63+
assert(
64+
process.env.TEST_DEFAULT_CLUSTER_ID,
65+
"TEST_DEFAULT_CLUSTER_ID doesn't exist"
66+
);
6967
/* eslint-disable @typescript-eslint/naming-convention */
7068
const defaultBundleConfig = {
7169
bundle: {

packages/databricks-vscode/src/test/e2e/wdio.conf.ts

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,7 @@ export const config: Options.Testrunner = {
315315
await config.ensureResolved();
316316

317317
assert(config.host, "Config host must be set");
318-
assert(
319-
config.token || (config.clientId && config.clientSecret),
320-
"Config must have a token or a clientId with clientSecret"
321-
);
318+
assert(config.token, "Config token must be set");
322319

323320
assert(
324321
process.env["TEST_DEFAULT_CLUSTER_ID"],
@@ -329,13 +326,8 @@ export const config: Options.Testrunner = {
329326
console.log(`Creating vscode workspace folder: ${WORKSPACE_PATH}`);
330327
await fs.mkdir(WORKSPACE_PATH, {recursive: true});
331328

332-
if (config.token) {
333-
const client = getWorkspaceClient(config);
334-
await startCluster(
335-
client,
336-
process.env["TEST_DEFAULT_CLUSTER_ID"]
337-
);
338-
}
329+
const client = getWorkspaceClient(config);
330+
await startCluster(client, process.env["TEST_DEFAULT_CLUSTER_ID"]);
339331

340332
process.env.DATABRICKS_HOST = config.host!;
341333
process.env.DATABRICKS_VSCODE_INTEGRATION_TEST = "true";
@@ -607,17 +599,12 @@ export const config: Options.Testrunner = {
607599

608600
async function writeDatabricksConfig(config: Config, rootPath: string) {
609601
const configFile = path.join(rootPath, ".databrickscfg");
610-
let content = "[DEFAULT]\n";
611-
if (config.token) {
612-
content += `host = ${config.host!}\n`;
613-
content += `token = ${config.token!}\n`;
614-
} else {
615-
content += `host = ${config.host!}\n`;
616-
content += `client_id = ${config.clientId!}\n`;
617-
content += `client_secret = ${config.clientSecret!}\n`;
618-
content += `serverless_compute_id = auto\n`;
619-
}
620-
await fs.writeFile(configFile, content);
602+
await fs.writeFile(
603+
configFile,
604+
`[DEFAULT]
605+
host = ${config.host!}
606+
token = ${config.token!}`
607+
);
621608
return configFile;
622609
}
623610

0 commit comments

Comments
 (0)