Skip to content

Commit 0053470

Browse files
authored
[Internal] Fix integration tests (#3902)
## Changes TestAccSQLEndpoint and TestAccWorkspaceConfFullLifecycle are currently failing on `main`. The former fails in GCP because @ is not allowed in a tag, so I've replaced it with _at_. The latter fails because of some checks of capitalization which I've fixed in this PR. Finally, TestMwsAccNetworkConnectivityConfig is failing on main but is a regression server-side. The test passed on commit 7a2fc352f77101b89c3692ab34c82606605cceed when it ran on August 8, but it now fails on the same commit. ## Tests Ran these integration tests locally, they pass. - [ ] `make test` run locally - [ ] relevant change in `docs/` folder - [ ] covered with integration tests in `internal/acceptance` - [ ] relevant acceptance tests are passing - [ ] using Go SDK
1 parent a59abf1 commit 0053470

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

internal/acceptance/sql_endpoint_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func TestAccSQLEndpoint(t *testing.T) {
2121
tags {
2222
custom_tags {
2323
key = "Owner"
24-
value = "eng-dev-ecosystem-team@databricks.com"
24+
value = "eng-dev-ecosystem-team_at_databricks.com"
2525
}
2626
}
2727
}`,
@@ -37,7 +37,7 @@ func TestAccSQLEndpoint(t *testing.T) {
3737
tags {
3838
custom_tags {
3939
key = "Owner"
40-
value = "eng-dev-ecosystem-team@databricks.com"
40+
value = "eng-dev-ecosystem-team_at_databricks.com"
4141
}
4242
}
4343
}`,

internal/acceptance/workspace_conf_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func assertEnableIpAccessList(t *testing.T, expected string) {
2020
})
2121
require.NoError(t, err)
2222
assert.Len(t, *conf, 1)
23-
assert.Equal(t, (*conf)["enableIpAccessLists"], expected)
23+
assert.Equal(t, expected, (*conf)["enableIpAccessLists"])
2424
}
2525

2626
func TestAccWorkspaceConfFullLifecycle(t *testing.T) {
@@ -70,11 +70,11 @@ func TestAccWorkspaceConfFullLifecycle(t *testing.T) {
7070
}`,
7171
Check: func(s *terraform.State) error {
7272
// Assert server side configuration is updated
73-
assertEnableIpAccessList(t, "true")
73+
assertEnableIpAccessList(t, "TRue")
7474

7575
// Assert state is persisted
7676
conf := s.RootModule().Resources["databricks_workspace_conf.this"]
77-
assert.Equal(t, "true", conf.Primary.Attributes["custom_config.enableIpAccessLists"])
77+
assert.Equal(t, "TRue", conf.Primary.Attributes["custom_config.enableIpAccessLists"])
7878
return nil
7979
},
8080
})

0 commit comments

Comments
 (0)