Skip to content

Commit 06a7422

Browse files
authored
Document output attributes in databricks_storage_credential (#5093)
## Changes <!-- Summary of your changes that are easy to understand --> For unknown reason, the `aws_iam_role.external_id` wasn't documented although was used in the examples. Fixing that problem ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] `make test` run locally - [x] relevant change in `docs/` folder - [x] has entry in `NEXT_CHANGELOG.md` file
1 parent 0c0272a commit 06a7422

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

NEXT_CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Breaking Changes
66

77
* Remove stale resources/datasources/documentation related to Clean Room services.
8-
8+
99
### New Features and Improvements
1010

1111
* Add `arm` option to `databricks_node_type` instead of `graviton` ([#5028](https://github.com/databricks/terraform-provider-databricks/pull/5028))
@@ -18,6 +18,7 @@
1818
### Documentation
1919

2020
* Add instructions for migration from deprecated `databricks_catalog_workspace_binding` to `databricks_workspace_binding` ([#5054](https://github.com/databricks/terraform-provider-databricks/pull/5054))
21+
* Document output attributes in `databricks_storage_credential` ([#5093](https://github.com/databricks/terraform-provider-databricks/pull/5093))
2122

2223
### Exporter
2324

docs/resources/storage_credential.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ The following arguments are required:
8686

8787
`aws_iam_role` optional configuration block for credential details for AWS:
8888

89-
- `role_arn` - The Amazon Resource Name (ARN) of the AWS IAM role for S3 data access, of the form `arn:aws:iam::1234567890:role/MyRole-AJJHDSKSDF`
89+
- `role_arn` - The Amazon Resource Name (ARN) of the AWS IAM role for S3 data access, of the form `arn:aws:iam::1234567890:role/MyRole-AJJHDSKSDF`.
9090

9191
`azure_managed_identity` optional configuration block for using managed identity as credential details for Azure (recommended over service principal):
9292

@@ -116,6 +116,10 @@ In addition to all arguments above, the following attributes are exported:
116116

117117
- `id` - ID of this storage credential - same as the `name`.
118118
- `storage_credential_id` - Unique ID of storage credential.
119+
- `aws_iam_role` exposes two additional attributes:
120+
121+
- `external_id` - The external ID used in role assumption to prevent the confused deputy problem.
122+
- `unity_catalog_iam_arn` - The Amazon Resource Name (ARN) of the AWS IAM user managed by Databricks. This is the identity that is going to assume the AWS IAM role.
119123

120124
## Import
121125

@@ -144,5 +148,5 @@ Alternatively, when using `terraform` version 1.4 or earlier, import using the `
144148
terraform import databricks_storage_credential.this <storage_credential_name>
145149

146150
# When using an account-level provider
147-
terraform import databricks_storage_credential.this <metastore_id>|<storage_credential_name>
151+
terraform import databricks_storage_credential.this '<metastore_id>|<storage_credential_name>'
148152
```

0 commit comments

Comments
 (0)