Skip to content

Commit 07de519

Browse files
Bump Go SDK version to 0.61.0 (#4602)
## Changes Bump Go SDK version to 0.61.0 and fix compilation issues: * Jobs uses 2.2 API, which broke many unit tests. * `apierr.NotFound` helper method removed from Go SDK. Errors are not explicitly created. ## Tests - [X] `make test` run locally - [ ] relevant change in `docs/` folder - [X] covered with integration tests in `internal/acceptance` - [X] using Go SDK - [ ] using TF Plugin Framework --------- Co-authored-by: Omer Lachish <[email protected]> Co-authored-by: Omer Lachish <[email protected]>
1 parent a76703c commit 07de519

File tree

90 files changed

+4734
-1020
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+4734
-1020
lines changed

.codegen/_openapi_sha

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e5c870006a536121442cfd2441bdc8a5fb76ae1e
1+
31b3fea21dbe5a3a652937691602eb66d6dba30b

.gitattributes

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
1+
common/client.go linguist-generated=true
2+
common/util.go linguist-generated=true
3+
internal/providers/common/common.go linguist-generated=true
4+
internal/providers/pluginfw/common/common.go linguist-generated=true
5+
internal/providers/pluginfw/context/context.go linguist-generated=true
6+
internal/providers/pluginfw/converters/tf_to_go.go linguist-generated=true
17
internal/providers/pluginfw/products/budget_policy/data_budget_policies.go linguist-generated=true
28
internal/providers/pluginfw/products/budget_policy/data_budget_policy.go linguist-generated=true
39
internal/providers/pluginfw/products/budget_policy/resource_budget_policy.go linguist-generated=true
10+
internal/providers/pluginfw/tfschema/customizable_schema.go linguist-generated=true
11+
internal/providers/pluginfw/tfschema/struct_to_schema.go linguist-generated=true
412
internal/service/apps_tf/legacy_model.go linguist-generated=true
513
internal/service/apps_tf/model.go linguist-generated=true
614
internal/service/billing_tf/legacy_model.go linguist-generated=true
@@ -41,3 +49,4 @@ internal/service/vectorsearch_tf/legacy_model.go linguist-generated=true
4149
internal/service/vectorsearch_tf/model.go linguist-generated=true
4250
internal/service/workspace_tf/legacy_model.go linguist-generated=true
4351
internal/service/workspace_tf/model.go linguist-generated=true
52+
internal/tfreflect/reflect_utils.go linguist-generated=true

NEXT_CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,5 @@
2828
* Fix panic caused by incorrect values in the cluster policies ([#4585](https://github.com/databricks/terraform-provider-databricks/pull/4585))
2929

3030
### Internal Changes
31+
32+
* Bump Go SDK version to 0.61.0 ([#4602](https://github.com/databricks/terraform-provider-databricks/pull/4602))

access/resource_permission_assignment.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@ func (l PermissionAssignmentList) ForPrincipal(principalId int64) (res Permissio
5656
}
5757
return Permissions{v.Permissions}, nil
5858
}
59-
return res, apierr.NotFound(fmt.Sprintf("%d not found", principalId))
59+
return res, &apierr.APIError{
60+
ErrorCode: "NOT_FOUND",
61+
StatusCode: 404,
62+
Message: fmt.Sprintf("%d not found", principalId),
63+
}
6064
}
6165

6266
func (a PermissionAssignmentAPI) List() (list PermissionAssignmentList, err error) {

access/resource_sql_permissions.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,11 @@ func (ta *SqlPermissions) read() error {
122122
failure := currentGrantsOnThis.Error()
123123
if strings.Contains(failure, "does not exist") ||
124124
strings.Contains(failure, "RESOURCE_DOES_NOT_EXIST") {
125-
return apierr.NotFound(failure)
125+
return &apierr.APIError{
126+
ErrorCode: "NOT_FOUND",
127+
StatusCode: 404,
128+
Message: failure,
129+
}
126130
}
127131
return fmt.Errorf("cannot read current grants: %s", failure)
128132
}

aws/resource_group_instance_profile.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ func ResourceGroupInstanceProfile() common.Resource {
2222
group, err := scim.NewGroupsAPI(ctx, c).Read(groupID, "roles")
2323
hasRole := scim.ComplexValues(group.Roles).HasValue(roleARN)
2424
if err == nil && !hasRole {
25-
return apierr.NotFound("Group has no instance profile")
25+
return &apierr.APIError{
26+
ErrorCode: "NOT_FOUND",
27+
StatusCode: 404,
28+
Message: "Group has no instance profile",
29+
}
2630
}
2731
return err
2832
},

aws/resource_instance_profile.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,12 @@ func (a InstanceProfilesAPI) Read(instanceProfileARN string) (result InstancePro
6060
return
6161
}
6262
}
63-
err = apierr.NotFound(fmt.Sprintf("Instance profile with name: %s not found in "+
64-
"list of instance profiles in the workspace!", instanceProfileARN))
63+
err = &apierr.APIError{
64+
ErrorCode: "NOT_FOUND",
65+
StatusCode: 404,
66+
Message: fmt.Sprintf("Instance profile with name: %s not found in "+
67+
"list of instance profiles in the workspace!", instanceProfileARN),
68+
}
6569
return
6670
}
6771

aws/resource_service_principal_role.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,11 @@ func ResourceServicePrincipalRole() common.Resource {
1919
servicePrincipal, err := scim.NewServicePrincipalsAPI(ctx, c).Read(servicePrincipalID, "roles")
2020
hasRole := scim.ComplexValues(servicePrincipal.Roles).HasValue(roleARN)
2121
if err == nil && !hasRole {
22-
return apierr.NotFound("Service Principal has no role")
22+
return &apierr.APIError{
23+
ErrorCode: "NOT_FOUND",
24+
StatusCode: 404,
25+
Message: "Service Principal has no role",
26+
}
2327
}
2428
return err
2529
},

aws/resource_user_instance_profile.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ func ResourceUserInstanceProfile() common.Resource {
2525
user, err := scim.NewUsersAPI(ctx, c).Read(userID, "roles")
2626
hasRole := scim.ComplexValues(user.Roles).HasValue(roleARN)
2727
if err == nil && !hasRole {
28-
return apierr.NotFound("User has no role")
28+
return &apierr.APIError{
29+
ErrorCode: "NOT_FOUND",
30+
StatusCode: 404,
31+
Message: "User has no role",
32+
}
2933
}
3034
return err
3135
},

aws/resource_user_role.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ func ResourceUserRole() common.Resource {
1818
user, err := scim.NewUsersAPI(ctx, c).Read(userID, "roles")
1919
hasRole := scim.ComplexValues(user.Roles).HasValue(roleARN)
2020
if err == nil && !hasRole {
21-
return apierr.NotFound("User has no role")
21+
return &apierr.APIError{
22+
ErrorCode: "NOT_FOUND",
23+
StatusCode: 404,
24+
Message: "User has no role",
25+
}
2226
}
2327
return err
2428
},

0 commit comments

Comments
 (0)