Don't consider GPU-based nodes in databricks_node_type data source until explicitly requested (#1978)

Author: alexott

clusters/data_node_type.go

@@ -163,7 +163,7 @@ func (a ClustersAPI) GetSmallestNodeType(r NodeTypeRequest) string {
 		if r.MinCores > 0 && int32(nt.NumCores) < r.MinCores {
 			continue
 		}
-		if r.MinGPUs > 0 && nt.NumGPUs < r.MinGPUs {
+		if (r.MinGPUs > 0 && nt.NumGPUs < r.MinGPUs) || (r.MinGPUs == 0 && nt.NumGPUs > 0) {
 			continue
 		}
 		if (r.LocalDisk || r.LocalDiskMinSize > 0) && nt.NodeInstanceType != nil &&

clusters/data_node_type_test.go

@@ -152,12 +152,19 @@ func TestNodeTypeCategory(t *testing.T) {
 							},
 							Category: "Memory Optimized",
 						},
+						{
+							NodeTypeID:     "Random_02_GPU",
+							InstanceTypeID: "Random_02_GPU",
+							MemoryMB:       8192,
+							NumCores:       8,
+							NumGPUs:        2,
+							Category:       "Storage Optimized",
+						},
 						{
 							NodeTypeID:     "Random_02",
 							InstanceTypeID: "Random_02",
 							MemoryMB:       8192,
 							NumCores:       8,
-							NumGPUs:        2,
 							Category:       "Storage Optimized",
 						},
 					},
@@ -282,7 +289,6 @@ func TestNodeTypeCategoryNotAvailable(t *testing.T) {
 							InstanceTypeID: "Random_03",
 							MemoryMB:       8192,
 							NumCores:       8,
-							NumGPUs:        2,
 							Category:       "Storage Optimized",
 						},
 					},