mark storage_root optional for databricks_metastore resource (#2873)

* make `storage_root` optional for `databricks_metastore`

* fix struct

Author: nkvuong

catalog/resource_metastore.go

@@ -15,7 +15,7 @@ import (
 
 type MetastoreInfo struct {
 	Name                                        string `json:"name"`
-	StorageRoot                                 string `json:"storage_root" tf:"force_new"`
+	StorageRoot                                 string `json:"storage_root,omitempty" tf:"force_new"`
 	DefaultDacID                                string `json:"default_data_access_config_id,omitempty" tf:"suppress_diff"`
 	StorageRootCredentialId                     string `json:"storage_root_credential_id,omitempty" tf:"suppress_diff"`
 	Owner                                       string `json:"owner,omitempty" tf:"computed"`

docs/resources/metastore.md

@@ -67,7 +67,7 @@ resource "databricks_metastore_assignment" "this" {
 The following arguments are required:
 
 * `name` - Name of metastore.
-* `storage_root` - Path on cloud storage account, where managed `databricks_table` are stored. Change forces creation of a new resource.
+* `storage_root` - (Optional) Path on cloud storage account, where managed `databricks_table` are stored. Change forces creation of a new resource.
 * `region` - (Mandatory for account-level) The region of the metastore
 * `owner` - (Optional) Username/groupname/sp application_id of the metastore owner.
 * `delta_sharing_scope` - (Optional) Required along with `delta_sharing_recipient_token_lifetime_in_seconds`. Used to enable delta sharing on the metastore. Valid values: INTERNAL, INTERNAL_AND_EXTERNAL.
@@ -80,6 +80,7 @@ The following arguments are required:
 In addition to all arguments above, the following attributes are exported:
 
 * `id` - system-generated ID of this Unity Catalog Metastore.
+
 ## Import
 
 This resource can be imported by ID:

internal/acceptance/metastore_test.go

@@ -39,3 +39,35 @@ func TestUcAccMetastore(t *testing.T) {
 		t.Skipf("not available on %s", cloudEnv)
 	}
 }
+
+func TestUcAccRootlessMetastore(t *testing.T) {
+	cloudEnv := os.Getenv("CLOUD_ENV")
+	switch cloudEnv {
+	case "ucacct":
+		unityAccountLevel(t, step{
+			Template: `resource "databricks_metastore" "this" {
+				name = "{var.RANDOM}"
+				region = "us-east-1"
+				force_destroy = true
+			}`,
+		})
+	case "azure-ucacct":
+		unityAccountLevel(t, step{
+			Template: `resource "databricks_metastore" "this" {
+				name = "{var.RANDOM}"
+				region = "eastus"
+				force_destroy = true
+			}`,
+		})
+	case "gcp-accounts":
+		unityAccountLevel(t, step{
+			Template: `resource "databricks_metastore" "this" {
+				name = "{var.RANDOM}"
+				region = "us-east1"
+				force_destroy = true
+			}`,
+		})
+	default:
+		t.Skipf("not available on %s", cloudEnv)
+	}
+}