add account workspace setting type (#3415)

Author: nkvuong

settings/generic_setting.go

@@ -149,7 +149,7 @@ var _ workspaceSettingDefinition[struct{}] = workspaceSetting[struct{}]{}
 
 type accountSettingDefinition[T any] genericSettingDefinition[T, *databricks.AccountClient]
 
-// An account setting is a setting that is scoped to a workspace.
+// An account setting is a setting that is scoped to an account.
 type accountSetting[T any] struct {
 	// The struct corresponding to the setting. The schema of the Terraform resource will be generated from this struct.
 	// This struct must have an Etag field of type string.
@@ -199,6 +199,100 @@ func (w accountSetting[T]) GetId(t *T) string {
 
 var _ accountSettingDefinition[struct{}] = accountSetting[struct{}]{}
 
+type accountWorkspaceSettingDefinition[T any] genericSettingDefinition[T, *common.DatabricksClient]
+
+// An account workspace setting is a setting that can be scoped to either an account or a workspace.
+type accountWorkspaceSetting[T any] struct {
+	// The struct corresponding to the setting. The schema of the Terraform resource will be generated from this struct.
+	// This struct must have an Etag field of type string.
+	settingStruct T
+
+	// Read the setting from the server. The etag is provided as the third argument.
+	readAccFunc func(ctx context.Context, acc *databricks.AccountClient, etag string) (*T, error)
+
+	readWsFunc func(ctx context.Context, w *databricks.WorkspaceClient, etag string) (*T, error)
+
+	// Update the setting to the value specified by t, and return the new etag. If the setting name is user-settable,
+	// it will be provided in the third argument. If not, you must set the SettingName field appropriately. You must
+	// also set AllowMissing: true and the field mask to the field to update.
+	updateAccFunc func(ctx context.Context, w *databricks.AccountClient, setting T) (string, error)
+
+	updateWsFunc func(ctx context.Context, w *databricks.WorkspaceClient, setting T) (string, error)
+
+	// Delete the setting with the given etag, and return the new etag.
+	deleteAccFunc func(ctx context.Context, acc *databricks.AccountClient, etag string) (string, error)
+
+	deleteWsFunc func(ctx context.Context, w *databricks.WorkspaceClient, etag string) (string, error)
+
+	// Optional function to generate resource ID from the settings. If not provided, will use predefined value `global`
+	generateIdFunc func(setting *T) string
+}
+
+func (aw accountWorkspaceSetting[T]) SettingStruct() T {
+	return aw.settingStruct
+}
+func (aw accountWorkspaceSetting[T]) Read(ctx context.Context, c *common.DatabricksClient, etag string) (*T, error) {
+	if c.Config.IsAccountClient() {
+		a, err := c.AccountClient()
+		if err != nil {
+			return nil, err
+		}
+		return aw.readAccFunc(ctx, a, etag)
+	} else {
+		ws, err := c.WorkspaceClient()
+		if err != nil {
+			return nil, err
+		}
+		return aw.readWsFunc(ctx, ws, etag)
+	}
+}
+func (aw accountWorkspaceSetting[T]) Update(ctx context.Context, c *common.DatabricksClient, t T) (string, error) {
+	if c.Config.IsAccountClient() {
+		a, err := c.AccountClient()
+		if err != nil {
+			return "", err
+		}
+		return aw.updateAccFunc(ctx, a, t)
+	} else {
+		ws, err := c.WorkspaceClient()
+		if err != nil {
+			return "", err
+		}
+		return aw.updateWsFunc(ctx, ws, t)
+	}
+}
+func (aw accountWorkspaceSetting[T]) Delete(ctx context.Context, c *common.DatabricksClient, etag string) (string, error) {
+	if c.Config.IsAccountClient() {
+		a, err := c.AccountClient()
+		if err != nil {
+			return "", err
+		}
+		return aw.deleteAccFunc(ctx, a, etag)
+	} else {
+		ws, err := c.WorkspaceClient()
+		if err != nil {
+			return "", err
+		}
+		return aw.deleteWsFunc(ctx, ws, etag)
+	}
+}
+func (aw accountWorkspaceSetting[T]) GetETag(t *T) string {
+	return getEtag(t)
+}
+func (aw accountWorkspaceSetting[T]) SetETag(t *T, newEtag string) {
+	setEtag(t, newEtag)
+}
+
+func (aw accountWorkspaceSetting[T]) GetId(t *T) string {
+	id := defaultSettingId
+	if aw.generateIdFunc != nil {
+		id = aw.generateIdFunc(t)
+	}
+	return id
+}
+
+var _ accountWorkspaceSettingDefinition[struct{}] = accountWorkspaceSetting[struct{}]{}
+
 func makeSettingResource[T, U any](defn genericSettingDefinition[T, U]) common.Resource {
 	resourceSchema := common.StructToSchema(defn.SettingStruct(),
 		func(s map[string]*schema.Schema) map[string]*schema.Schema {
@@ -245,6 +339,18 @@ func makeSettingResource[T, U any](defn genericSettingDefinition[T, U]) common.R
 			if err != nil {
 				return err
 			}
+		case accountWorkspaceSettingDefinition[T]:
+			var err error
+			res, err = retryOnEtagError(
+				func(setting T) (string, error) {
+					return defn.Update(ctx, c, setting)
+				},
+				setting,
+				defn.SetETag,
+				createOrUpdateRetriableErrors)
+			if err != nil {
+				return err
+			}
 		default:
 			return fmt.Errorf("unexpected setting type: %T", defn)
 		}
@@ -280,6 +386,12 @@ func makeSettingResource[T, U any](defn genericSettingDefinition[T, U]) common.R
 				if err != nil {
 					return err
 				}
+			case accountWorkspaceSettingDefinition[T]:
+				var err error
+				res, err = defn.Read(ctx, c, d.Get(etagAttrName).(string))
+				if err != nil {
+					return err
+				}
 			default:
 				return fmt.Errorf("unexpected setting type: %T", defn)
 			}
@@ -333,6 +445,18 @@ func makeSettingResource[T, U any](defn genericSettingDefinition[T, U]) common.R
 				if err != nil {
 					return err
 				}
+			case accountWorkspaceSettingDefinition[T]:
+				var err error
+				etag, err = retryOnEtagError(
+					func(etag string) (string, error) {
+						return defn.Delete(ctx, c, etag)
+					},
+					d.Get(etagAttrName).(string),
+					updateETag,
+					deleteRetriableErrors)
+				if err != nil {
+					return err
+				}
 			default:
 				return fmt.Errorf("unexpected setting type: %T", defn)
 			}