[Internal] Catalog tests cleanup to use plan checks (#5112)

## Changes
<!-- Summary of your changes that are easy to understand -->
We use the internal library to checking planned actions.

## Tests
<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->
Integration test

---------

Co-authored-by: Alex Ott <[email protected]>

Author: tanmay-db

NEXT_CHANGELOG.md

@@ -18,3 +18,4 @@
 ### Exporter
 
 ### Internal Changes
+* Refactor `catalog_test.go` to use internal plan checks ([#5112](https://github.com/databricks/terraform-provider-databricks/pull/5112)).

catalog/catalog_test.go

@@ -1,15 +1,12 @@
 package catalog_test
 
 import (
-	"context"
 	"fmt"
 	"regexp"
-	"strings"
 	"testing"
 
 	"github.com/databricks/terraform-provider-databricks/internal/acceptance"
 	"github.com/databricks/terraform-provider-databricks/qa"
-	tfjson "github.com/hashicorp/terraform-json"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/plancheck"
 )
@@ -62,35 +59,6 @@ func TestUcAccCatalogIsolated(t *testing.T) {
 	})
 }
 
-type checkResourceRecreate struct {
-	address string
-}
-
-func (c checkResourceRecreate) CheckPlan(ctx context.Context, req plancheck.CheckPlanRequest, resp *plancheck.CheckPlanResponse) {
-	var change *tfjson.ResourceChange
-	for _, resourceChange := range req.Plan.ResourceChanges {
-		if resourceChange.Address == c.address {
-			change = resourceChange
-			break
-		}
-	}
-	if change == nil {
-		addressesWithPlannedChanges := make([]string, 0, len(req.Plan.ResourceChanges))
-		for _, change := range req.Plan.ResourceChanges {
-			addressesWithPlannedChanges = append(addressesWithPlannedChanges, change.Address)
-		}
-		resp.Error = fmt.Errorf("address %s not found in resource changes; only planned changes for addresses %s", c.address, strings.Join(addressesWithPlannedChanges, ", "))
-		return
-	}
-	if change.Change.Actions[0] != tfjson.ActionDelete {
-		plannedActions := make([]string, 0, len(change.Change.Actions))
-		for _, action := range change.Change.Actions {
-			plannedActions = append(plannedActions, string(action))
-		}
-		resp.Error = fmt.Errorf("no delete is planned for %s; planned actions are: %s", c.address, strings.Join(plannedActions, ", "))
-	}
-}
-
 func TestUcAccCatalogUpdate(t *testing.T) {
 	acceptance.LoadUcwsEnv(t)
 	acceptance.UnityWorkspaceLevel(t, acceptance.Step{
@@ -153,7 +121,7 @@ func TestUcAccCatalogUpdate(t *testing.T) {
 		}`, getPredictiveOptimizationSetting(t, false)),
 		ConfigPlanChecks: resource.ConfigPlanChecks{
 			PreApply: []plancheck.PlanCheck{
-				checkResourceRecreate{address: "databricks_catalog.sandbox"},
+				plancheck.ExpectResourceAction("databricks_catalog.sandbox", plancheck.ResourceActionDestroyBeforeCreate),
 			},
 		},
 	})