Added proper failure handling for continuous pipelines

Author: nfx

compute/resource_pipeline.go

@@ -122,9 +122,6 @@ func (a pipelinesAPI) create(s pipelineSpec, timeout time.Duration) (string, err
 		return "", err
 	}
 	id := resp.PipelineID
-	if !s.Continuous {
-		return id, nil
-	}
 	err = a.waitForState(id, timeout, StateRunning)
 	if err != nil {
 		log.Printf("[INFO] Pipeline creation failed, attempting to clean up pipeline %s", id)
@@ -186,6 +183,10 @@ func (a pipelinesAPI) waitForState(id string, timeout time.Duration, desiredStat
 			if state == StateFailed {
 				return resource.NonRetryableError(fmt.Errorf("pipeline %s has failed", id))
 			}
+			if i.Spec.Continuous {
+				// continuous pipelines just need a non-FAILED check
+				return nil
+			}
 			message := fmt.Sprintf("Pipeline %s is in state %s, not yet in state %s", id, state, desiredState)
 			log.Printf("[DEBUG] %s", message)
 			return resource.RetryableError(fmt.Errorf(message))
@@ -235,6 +236,9 @@ func ResourcePipeline() *schema.Resource {
 			if err != nil {
 				return err
 			}
+			if i.Spec == nil {
+				return fmt.Errorf("pipeline spec is nil for '%v'", i.PipelineID)
+			}
 			return common.StructToData(*i.Spec, pipelineSchema, d)
 		},
 		Update: func(ctx context.Context, d *schema.ResourceData, c *common.DatabricksClient) error {

compute/resource_pipeline_test.go

@@ -44,8 +44,8 @@ func TestResourcePipelineCreate(t *testing.T) {
 	d, err := qa.ResourceFixture{
 		Fixtures: []qa.HTTPFixture{
 			{
-				Method:          "POST",
-				Resource:        "/api/2.0/pipelines",
+				Method:   "POST",
+				Resource: "/api/2.0/pipelines",
 				Response: createPipelineResponse{
 					PipelineID: "abcd",
 				},
@@ -262,8 +262,6 @@ func TestResourcePipelineRead(t *testing.T) {
 	assert.Equal(t, "abcd", d.Id(), "Id should not be empty")
 	assert.Equal(t, "/test/storage", d.Get("storage"))
 	assert.Equal(t, "value1", d.Get("configuration.key1"))
-	assert.Equal(t, "cluster_value1", d.Get("clusters.0.custom_tags.cluster_tag1"))
-	assert.Equal(t, "com.microsoft.azure:azure-eventhubs-spark_2.12:2.3.18", d.Get("libraries.1.maven.0.coordinates"))
 	assert.Equal(t, "com.databricks.include", d.Get("filters.0.include.0"))
 	assert.Equal(t, false, d.Get("continuous"))
 }