Allow using empty strings as job parameters (#3158)

* Allow using empty strings as job parameters

* Add unit tests

* Add acceptance test

* Fix parameter name in tests

Author: kanterov

internal/acceptance/job_test.go

@@ -90,8 +90,22 @@ func TestAccJobTasks(t *testing.T) {
 
 				notebook_task {
 					notebook_path = databricks_notebook.this.path
+					base_parameters = {
+						"param_0" = "{{job.parameters.empty_default}}"
+						"param_0" = "{{job.parameters.non_empty_default}}"
+					}
 				}
 			}
+
+			parameter {
+				name = "empty_default"
+				default = ""
+			}
+
+			parameter {
+				name = "non_empty_default"
+				default = "non_empty"
+			}
 		}`,
 	})
 }

jobs/resource_job.go

@@ -273,7 +273,7 @@ type JobSettings struct {
 	Queue                *jobs.QueueSettings           `json:"queue,omitempty"`
 	RunAs                *JobRunAs                     `json:"run_as,omitempty" tf:"computed"`
 	Health               *JobHealth                    `json:"health,omitempty"`
-	Parameters           []JobParameterDefinition      `json:"parameters,omitempty" tf:"alias:parameter"`
+	Parameters           []jobs.JobParameterDefinition `json:"parameters,omitempty" tf:"alias:parameter"`
 	Deployment           *jobs.JobDeployment           `json:"deployment,omitempty"`
 	EditMode             jobs.CreateJobEditMode        `json:"edit_mode,omitempty"`
 }
@@ -342,12 +342,6 @@ type JobParameter struct {
 	Value   string `json:"value,omitempty"`
 }
 
-// Job-level parameter definitions
-type JobParameterDefinition struct {
-	Name    string `json:"name,omitempty"`
-	Default string `json:"default,omitempty"`
-}
-
 // RunState of the job
 type RunState struct {
 	ResultState    string `json:"result_state,omitempty"`

jobs/resource_job_test.go

@@ -553,7 +553,7 @@ func TestResourceJobCreate_JobParameters(t *testing.T) {
 						},
 					},
 					MaxConcurrentRuns: 1,
-					Parameters: []JobParameterDefinition{
+					Parameters: []jobs.JobParameterDefinition{
 						{
 							Name:    "hello",
 							Default: "world",
@@ -582,7 +582,7 @@ func TestResourceJobCreate_JobParameters(t *testing.T) {
 								TaskKey: "b",
 							},
 						},
-						Parameters: []JobParameterDefinition{
+						Parameters: []jobs.JobParameterDefinition{
 							{
 								Name:    "hello",
 								Default: "world",
@@ -621,6 +621,88 @@ func TestResourceJobCreate_JobParameters(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t, "231", d.Id())
 }
+
+func TestResourceJobCreate_JobParameters_EmptyDefault(t *testing.T) {
+	d, err := qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "POST",
+				Resource: "/api/2.1/jobs/create",
+				ExpectedRequest: JobSettings{
+					Name:              "JobParameterTesting",
+					MaxConcurrentRuns: 1,
+					Tasks: []JobTaskSettings{
+						{
+							TaskKey: "a",
+						},
+					},
+					Parameters: []jobs.JobParameterDefinition{
+						{
+							Name:    "key",
+							Default: "",
+						},
+					},
+				},
+				Response: Job{
+					JobID: 231,
+				},
+			},
+			{
+				Method:   "GET",
+				Resource: "/api/2.1/jobs/get?job_id=231",
+				Response: Job{
+					// good enough for mock
+					Settings: &JobSettings{
+						Tasks: []JobTaskSettings{
+							{
+								TaskKey: "a",
+							},
+						},
+						Parameters: []jobs.JobParameterDefinition{
+							{
+								Name:    "key",
+								Default: "",
+							},
+						},
+					},
+				},
+			},
+		},
+		Create:   true,
+		Resource: ResourceJob(),
+		HCL: `
+		name = "JobParameterTesting"
+
+		parameter {
+				name = "key"
+				default = ""
+		}
+
+		task {
+			task_key = "a"
+		}`,
+	}.Apply(t)
+	assert.NoError(t, err)
+	assert.Equal(t, "231", d.Id())
+}
+
+func TestResourceJobCreate_JobParameters_DefaultIsRequired(t *testing.T) {
+	qa.ResourceFixture{
+		Create:   true,
+		Resource: ResourceJob(),
+		HCL: `
+		name = "JobParameterTesting"
+
+		parameter {
+				name = "key"
+		}
+
+		task {
+			task_key = "a"
+		}`,
+	}.ExpectError(t, "invalid config supplied. [parameter.#.default] Missing required argument")
+}
+
 func TestResourceJobCreate_JobClusters(t *testing.T) {
 	d, err := qa.ResourceFixture{
 		Fixtures: []qa.HTTPFixture{