Exporter: optimize generation of databricks_group_member resource (#3559)

With this change we're generating resource data directly because we have all necessary
information - this should decrease the number of REST API calls to SCIM API because the
Read operation of `databricks_group_member` reads a group for each group member.

Author: alexott

exporter/importables.go

@@ -903,10 +903,12 @@ var resourcesMap map[string]importable = map[string]importable{
 						ID:       parent.Value,
 					})
 					if parent.Type == "direct" {
+						id := fmt.Sprintf("%s|%s", parent.Value, g.ID)
 						ic.Emit(&resource{
 							Resource: "databricks_group_member",
-							ID:       fmt.Sprintf("%s|%s", parent.Value, g.ID),
+							ID:       id,
 							Name:     fmt.Sprintf("%s_%s_%s", parent.Display, parent.Value, g.DisplayName),
+							Data:     ic.makeGroupMemberData(id, parent.Value, g.ID),
 						})
 					}
 				}
@@ -917,10 +919,12 @@ var resourcesMap map[string]importable = map[string]importable{
 							ID:       x.Value,
 						})
 						if !builtInUserGroup {
+							id := fmt.Sprintf("%s|%s", g.ID, x.Value)
 							ic.Emit(&resource{
 								Resource: "databricks_group_member",
-								ID:       fmt.Sprintf("%s|%s", g.ID, x.Value),
+								ID:       id,
 								Name:     fmt.Sprintf("%s_%s_%s_%s", g.DisplayName, g.ID, x.Display, x.Value),
+								Data:     ic.makeGroupMemberData(id, g.ID, x.Value),
 							})
 						}
 					}
@@ -930,10 +934,12 @@ var resourcesMap map[string]importable = map[string]importable{
 							ID:       x.Value,
 						})
 						if !builtInUserGroup {
+							id := fmt.Sprintf("%s|%s", g.ID, x.Value)
 							ic.Emit(&resource{
 								Resource: "databricks_group_member",
-								ID:       fmt.Sprintf("%s|%s", g.ID, x.Value),
+								ID:       id,
 								Name:     fmt.Sprintf("%s_%s_%s_%s", g.DisplayName, g.ID, x.Display, x.Value),
+								Data:     ic.makeGroupMemberData(id, g.ID, x.Value),
 							})
 						}
 					}
@@ -943,10 +949,12 @@ var resourcesMap map[string]importable = map[string]importable{
 							ID:       x.Value,
 						})
 						if !builtInUserGroup {
+							id := fmt.Sprintf("%s|%s", g.ID, x.Value)
 							ic.Emit(&resource{
 								Resource: "databricks_group_member",
-								ID:       fmt.Sprintf("%s|%s", g.ID, x.Value),
+								ID:       id,
 								Name:     fmt.Sprintf("%s_%s_%s_%s", g.DisplayName, g.ID, x.Display, x.Value),
+								Data:     ic.makeGroupMemberData(id, g.ID, x.Value),
 							})
 						}
 					}

exporter/util.go

@@ -371,10 +371,12 @@ func (ic *importContext) emitGroups(u scim.User) {
 			Resource: "databricks_group",
 			ID:       g.Value,
 		})
+		id := fmt.Sprintf("%s|%s", g.Value, u.ID)
 		ic.Emit(&resource{
 			Resource: "databricks_group_member",
-			ID:       fmt.Sprintf("%s|%s", g.Value, u.ID),
+			ID:       id,
 			Name:     fmt.Sprintf("%s_%s_%s_%s", g.Display, g.Value, u.DisplayName, u.ID),
+			Data:     ic.makeGroupMemberData(id, g.Value, u.ID),
 		})
 	}
 }
@@ -1495,3 +1497,12 @@ func dltIsMatchingCatalogAndSchema(ic *importContext, res *resource, ra *resourc
 	result := ra_catalog_name.(string) == res_catalog_name && ra_schema_name.(string) == res_schema_name
 	return result
 }
+
+func (ic *importContext) makeGroupMemberData(id, groupId, memberId string) *schema.ResourceData {
+	data := scim.ResourceGroupMember().ToResource().TestResourceData()
+	data.MarkNewResource()
+	data.SetId(id)
+	data.Set("group_id", groupId)
+	data.Set("member_id", memberId)
+	return data
+}