[Fix] Remove incorrect customization for databricks_catalog (#5021)

## Changes
- foreign catalog can have both `connection_name` and `storage_root`

## Tests
<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] `make test` run locally
- [x] covered with integration tests in `internal/acceptance`
- [x] using Go SDK
- [x] has entry in `NEXT_CHANGELOG.md` file

Author: nkvuong

NEXT_CHANGELOG.md

@@ -10,6 +10,8 @@
 
 ### Bug Fixes
 
+* Remove incorrect customization for `databricks_catalog`
+
 ### Documentation
 
 ### Exporter

catalog/resource_catalog.go

@@ -44,8 +44,8 @@ func ResourceCatalog() common.Resource {
 			for _, v := range []string{"name", "connection_name", "share_name", "provider_name"} {
 				common.CustomizeSchemaPath(s, v).SetCustomSuppressDiff(common.EqualFoldDiffSuppress)
 			}
-			// can only have one of provider_name + share_name, connection_name or storage_root
-			common.CustomizeSchemaPath(s, "connection_name").SetConflictsWith([]string{"storage_root", "provider_name", "share_name"}).SetForceNew()
+			// can only have one of provider_name + share_name, connection_name
+			common.CustomizeSchemaPath(s, "connection_name").SetConflictsWith([]string{"provider_name", "share_name"}).SetForceNew()
 			for _, v := range []string{"provider_name", "share_name"} {
 				common.CustomizeSchemaPath(s, v).SetConflictsWith([]string{"connection_name", "storage_root"}).SetForceNew()
 			}

catalog/resource_catalog_test.go

@@ -630,7 +630,7 @@ func TestCatalogCreateDeltaSharing(t *testing.T) {
 }
 
 func TestCatalogCreateForeign(t *testing.T) {
-	d, err := qa.ResourceFixture{
+	qa.ResourceFixture{
 		MockWorkspaceClientFunc: func(w *mocks.MockWorkspaceClient) {
 			e := w.GetMockCatalogsAPI().EXPECT()
 			e.Create(mock.Anything, catalog.CreateCatalog{
@@ -665,12 +665,65 @@ func TestCatalogCreateForeign(t *testing.T) {
 		}
 		connection_name = "foo"
 		`,
-	}.Apply(t)
-	assert.NoError(t, err)
-	assert.Equal(t, "foreign_catalog", d.Get("name"))
-	assert.Equal(t, "foo", d.Get("connection_name"))
-	assert.Equal(t, "b", d.Get("comment"))
-	assert.Equal(t, map[string]interface{}{"database": "abcd"}, d.Get("options"))
+	}.ApplyAndExpectData(t, map[string]any{
+		"name":            "foreign_catalog",
+		"comment":         "b",
+		"connection_name": "foo",
+		"options": map[string]any{
+			"database": "abcd",
+		},
+	})
+}
+
+func TestCatalogCreateForeignIceberg(t *testing.T) {
+	qa.ResourceFixture{
+		MockWorkspaceClientFunc: func(w *mocks.MockWorkspaceClient) {
+			e := w.GetMockCatalogsAPI().EXPECT()
+			e.Create(mock.Anything, catalog.CreateCatalog{
+				Name:           "foreign_catalog",
+				Comment:        "b",
+				Options:        map[string]string{"database": "abcd"},
+				ConnectionName: "foo",
+				StorageRoot:    "s3://my-bucket/warehouse",
+			}).Return(&catalog.CatalogInfo{
+				Name:           "foreign_catalog",
+				Comment:        "b",
+				Options:        map[string]string{"database": "abcd"},
+				ConnectionName: "foo",
+				MetastoreId:    "e",
+				StorageRoot:    "s3://my-bucket/warehouse",
+				Owner:          "f",
+			}, nil)
+			e.GetByName(mock.Anything, "foreign_catalog").Return(&catalog.CatalogInfo{
+				Name:           "foreign_catalog",
+				Comment:        "b",
+				Options:        map[string]string{"database": "abcd"},
+				ConnectionName: "foo",
+				MetastoreId:    "e",
+				StorageRoot:    "s3://my-bucket/warehouse",
+				Owner:          "f",
+			}, nil)
+		},
+		Resource: ResourceCatalog(),
+		Create:   true,
+		HCL: `
+		name = "foreign_catalog"
+		comment = "b"
+		options = {
+			database = "abcd"
+		}
+		connection_name = "foo"
+		storage_root = "s3://my-bucket/warehouse"
+		`,
+	}.ApplyAndExpectData(t, map[string]any{
+		"name":            "foreign_catalog",
+		"comment":         "b",
+		"connection_name": "foo",
+		"options": map[string]any{
+			"database": "abcd",
+		},
+		"storage_root": "s3://my-bucket/warehouse",
+	})
 }
 
 func TestCatalogCreateIsolated(t *testing.T) {