Added validation for path in databricks_repo (#1702)

It was reported by user that error message isn't understandable, so this PR improves this

Author: alexott

repos/resource_repo.go

@@ -55,14 +55,7 @@ func (a ReposAPI) Create(r reposCreateRequest) (ReposInformation, error) {
 		return resp, fmt.Errorf("git_provider isn't specified and we can't detect provider from URL")
 	}
 	if r.Path != "" {
-		if !strings.HasPrefix(r.Path, "/Repos/") {
-			return resp, fmt.Errorf("path should start with /Repos/")
-		}
-		p := r.Path
-		if strings.HasSuffix(r.Path, "/") {
-			p = strings.TrimSuffix(r.Path, "/")
-		}
-		p = path.Dir(p)
+		p := path.Dir(strings.TrimSuffix(r.Path, "/"))
 		if err := workspace.NewNotebooksAPI(a.context, a.client).Mkdirs(p); err != nil {
 			return resp, err
 		}
@@ -151,6 +144,23 @@ func GetGitProviderFromUrl(uri string) string {
 	return provider
 }
 
+func validatePath(i interface{}, k string) (_ []string, errors []error) {
+	v := i.(string)
+	if v != "" {
+		if !strings.HasPrefix(v, "/Repos/") {
+			errors = append(errors, fmt.Errorf("should start with /Repos/, got '%s'", v))
+			return
+		}
+		v = strings.TrimSuffix(v, "/")
+		parts := strings.Split(v, "/")
+		if len(parts) != 4 { // we require 3 path parts + starting /
+			errors = append(errors, fmt.Errorf("should have 3 components (/Repos/<directory>/<repo>), got %d", len(parts)-1))
+			return
+		}
+	}
+	return
+}
+
 func ResourceRepo() *schema.Resource {
 	s := common.StructToSchema(ReposInformation{}, func(s map[string]*schema.Schema) map[string]*schema.Schema {
 		s["url"].ValidateFunc = validation.IsURLWithScheme([]string{"https", "http"})
@@ -159,6 +169,7 @@ func ResourceRepo() *schema.Resource {
 		}
 		s["branch"].ConflictsWith = []string{"tag"}
 		s["branch"].ValidateFunc = validation.StringIsNotWhiteSpace
+		s["path"].ValidateFunc = validatePath
 
 		s["tag"] = &schema.Schema{
 			Type:          schema.TypeString,

repos/resource_repo_test.go

@@ -18,7 +18,6 @@ func TestGetGitProviderFromUrl(t *testing.T) {
 	assert.Equal(t, "bitbucketCloud", GetGitProviderFromUrl("https://[email protected]/user/repo.git"))
 	assert.Equal(t, "gitHub", GetGitProviderFromUrl("https://github.com//user/repo.git"))
 	assert.Equal(t, "azureDevOpsServices", GetGitProviderFromUrl("https://[email protected]/user/project/_git/repo"))
-	//	assert.Equal(t, "bitbucketCloud", GetGitProviderFromUrl("https://[email protected]/user/repo.git"))
 	assert.Equal(t, "", GetGitProviderFromUrl("https://abc/user/repo.git"))
 	assert.Equal(t, "", GetGitProviderFromUrl("ewfgwergfwe"))
 	assert.Equal(t, "awsCodeCommit", GetGitProviderFromUrl("https://git-codecommit.us-east-2.amazonaws.com/v1/repos/MyDemoRepo"))
@@ -207,7 +206,18 @@ func TestResourceRepoCreateCustomDirectoryWrongLocation(t *testing.T) {
 			"path": "/NotRepos/Production/test/",
 		},
 		Create: true,
-	}.ExpectError(t, "path should start with /Repos/")
+	}.ExpectError(t, "invalid config supplied. [path] should start with /Repos/, got '/NotRepos/Production/test/'")
+}
+
+func TestResourceRepoCreateCustomDirectoryWrongPath(t *testing.T) {
+	qa.ResourceFixture{
+		Resource: ResourceRepo(),
+		State: map[string]any{
+			"url":  "https://github.com/user/test.git",
+			"path": "/Repos/test/",
+		},
+		Create: true,
+	}.ExpectError(t, "invalid config supplied. [path] should have 3 components (/Repos/<directory>/<repo>), got 2")
 }
 
 func TestResourceRepoCreateWithBranch(t *testing.T) {