Detect run_as drift in job resource (#2626)

* Detect run_as drift in job resource

* fix SP UUID drift

* suppress_diff for run_as

Author: dvkuznietsov

jobs/resource_job.go

@@ -292,7 +292,7 @@ type JobSettings struct {
 	NotificationSettings *jobs.JobNotificationSettings `json:"notification_settings,omitempty"`
 	Tags                 map[string]string             `json:"tags,omitempty"`
 	Queue                *Queue                        `json:"queue,omitempty"`
-	RunAs                *JobRunAs                     `json:"run_as,omitempty"`
+	RunAs                *JobRunAs                     `json:"run_as,omitempty" tf:"suppress_diff"`
 	Health               *JobHealth                    `json:"health,omitempty"`
 	Parameters           []JobParameterDefinition      `json:"parameters,omitempty" tf:"alias:parameter"`
 }
@@ -574,6 +574,21 @@ func (a JobsAPI) Read(id string) (job Job, err error) {
 		job.Settings.sortTasksByKey()
 		job.Settings.sortWebhooksByID()
 	}
+
+	if job.RunAsUserName != "" && job.Settings != nil {
+		userNameIsEmail := strings.Contains(job.RunAsUserName, "@")
+
+		if userNameIsEmail {
+			job.Settings.RunAs = &JobRunAs{
+				UserName: job.RunAsUserName,
+			}
+		} else {
+			job.Settings.RunAs = &JobRunAs{
+				ServicePrincipalName: job.RunAsUserName,
+			}
+		}
+	}
+
 	return
 }
 

jobs/resource_job_test.go

@@ -87,6 +87,9 @@ func TestResourceJobCreate(t *testing.T) {
 							PauseStatus:          "PAUSED",
 						},
 						Queue: &Queue{},
+						RunAs: &JobRunAs{
+							UserName: "[email protected]",
+						},
 					},
 				},
 			},