Enable Photon by default for every new databricks_sql_endpoint

Author: nfx

CHANGELOG.md

@@ -12,6 +12,7 @@
 * Added more selectors to `databricks_node_type` data source ([#723](https://github.com/databrickslabs/terraform-provider-databricks/pull/723))
 * Azure auth with SPN now uses AAD token by default instead of PAT. Previous behavior (using PAT) could be restored by setting `azure_use_pat_for_spn` to `true` ([#721](https://github.com/databrickslabs/terraform-provider-databricks/pull/721))
 * `deployment_name` for `databricks_mws_workspaces` is now optional, how it should have been. This enables creation of Databricks workspaces without an account prefix.
+* To replicate default behavior of Databricks SQL UI, `enable_photon` is now `true` by default for `databricks_sql_endpoint`.
 * Various documentation and bugfixes
 
 Updated dependency versions:

docs/resources/sql_endpoint.md

@@ -38,7 +38,7 @@ The following arguments are supported:
 * `instance_profile_arn` - [databricks_instance_profile](instance_profile.md) used to access storage from the SQL endpoint. This field is optional.
 * `tags` - Databricks tags all endpoint resources with these tags.
 * `spot_instance_policy` - The spot policy to use for allocating instances to clusters: `COST_OPTIMIZED` or `RELIABILITY_OPTIMIZED`. This field is optional. Default is `COST_OPTIMIZED`.
-* `enable_photon` - Whether to enable [Photon](https://databricks.com/product/delta-engine). This field is optional.
+* `enable_photon` - Whether to enable [Photon](https://databricks.com/product/delta-engine). This field is optional and is enabled by default.
 
 ## Attribute Reference
 

identity/scim.go

@@ -84,7 +84,7 @@ func addEntitlementsToSchema(s *map[string]*schema.Schema) {
 		(*s)[field_name] = &schema.Schema{
 			Type:     schema.TypeBool,
 			Optional: true,
-			Default: false,
+			Default:  false,
 		}
 	}
 }

sqlanalytics/resource_sql_endpoint.go

@@ -189,6 +189,7 @@ func ResourceSQLEndpoint() *schema.Resource {
 		m["min_num_clusters"].Default = 1
 		m["num_clusters"].Default = 1
 		m["spot_instance_policy"].Default = "COST_OPTIMIZED"
+		m["enable_photon"].Default = true
 		m["tags"].DiffSuppressFunc = common.MakeEmptyBlockSuppressFunc("tags.#")
 		return m
 	})

sqlanalytics/resource_sql_endpoint_test.go

@@ -78,6 +78,7 @@ func TestResourceSQLEndpointCreate(t *testing.T) {
 					AutoStopMinutes:    120,
 					MinNumClusters:     1,
 					NumClusters:        1,
+					EnablePhoton:       true,
 					SpotInstancePolicy: "COST_OPTIMIZED",
 				},
 				Response: SQLEndpoint{
@@ -116,16 +117,7 @@ func TestResourceSQLEndpointCreate_ErrorDisabled(t *testing.T) {
 			{
 				Method:   "POST",
 				Resource: "/api/2.0/sql/endpoints",
-				ExpectedRequest: SQLEndpoint{
-					Name:               "foo",
-					ClusterSize:        "Small",
-					AutoStopMinutes:    120,
-					MaxNumClusters:     1,
-					MinNumClusters:     1,
-					NumClusters:        1,
-					SpotInstancePolicy: "COST_OPTIMIZED",
-				},
-				Status: 404,
+				Status:   404,
 				Response: common.APIError{
 					ErrorCode: "FEATURE_DISABLED",
 					Message:   "Databricks SQL is not supported",
@@ -184,6 +176,7 @@ func TestResourceSQLEndpointUpdate(t *testing.T) {
 					MaxNumClusters:     1,
 					MinNumClusters:     1,
 					NumClusters:        1,
+					EnablePhoton:       true,
 					SpotInstancePolicy: "COST_OPTIMIZED",
 				},
 			},