Suppress diff for edition attribute in databricks_pipeline (#2219)

Added suppress diff for `edition` attribute for case when change is just case
sensitivity, i.e., `CORE` -> `core`, etc.

Author: alexott

common/resource.go

@@ -299,3 +299,11 @@ func WorkspaceData[T any](read func(context.Context, *T, *databricks.WorkspaceCl
 		},
 	}
 }
+
+func EqualFoldDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
+	if strings.EqualFold(old, new) {
+		log.Printf("[INFO] Suppressing diff on %s", k)
+		return true
+	}
+	return false
+}

common/resource_test.go

@@ -178,3 +178,8 @@ func TestCustomizeDiffRobustness(t *testing.T) {
 	err = r.CustomizeDiff(ctx, nil, nil)
 	assert.EqualError(t, err, "cannot customize diff for sample: panic: oops")
 }
+
+func TestEqualFoldDiffSuppress(t *testing.T) {
+	assert.True(t, EqualFoldDiffSuppress("k", "A", "a", nil))
+	assert.False(t, EqualFoldDiffSuppress("k", "A", "A2", nil))
+}

pipelines/resource_pipeline.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"log"
 	"regexp"
-	"strings"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
@@ -284,21 +283,13 @@ func suppressStorageDiff(k, old, new string, d *schema.ResourceData) bool {
 	return false
 }
 
-func AutoscaleModeDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
-	if strings.EqualFold(old, new) {
-		log.Printf("[INFO] Suppressing diff on autoscale mode")
-		return true
-	}
-	return false
-}
-
 func adjustPipelineResourceSchema(m map[string]*schema.Schema) map[string]*schema.Schema {
 	cluster, _ := m["cluster"].Elem.(*schema.Resource)
 	clustersSchema := cluster.Schema
 	clustersSchema["spark_conf"].DiffSuppressFunc = clusters.SparkConfDiffSuppressFunc
 	common.MustSchemaPath(clustersSchema,
 		"aws_attributes", "zone_id").DiffSuppressFunc = clusters.ZoneDiffSuppress
-	common.MustSchemaPath(clustersSchema, "autoscale", "mode").DiffSuppressFunc = AutoscaleModeDiffSuppress
+	common.MustSchemaPath(clustersSchema, "autoscale", "mode").DiffSuppressFunc = common.EqualFoldDiffSuppress
 
 	gcpAttributes, _ := clustersSchema["gcp_attributes"].Elem.(*schema.Resource)
 	gcpAttributesSchema := gcpAttributes.Schema
@@ -312,6 +303,7 @@ func adjustPipelineResourceSchema(m map[string]*schema.Schema) map[string]*schem
 	}
 	m["channel"].ValidateFunc = validation.StringInSlice([]string{"current", "preview"}, true)
 	m["edition"].ValidateFunc = validation.StringInSlice([]string{"pro", "core", "advanced"}, true)
+	m["edition"].DiffSuppressFunc = common.EqualFoldDiffSuppress
 
 	m["storage"].DiffSuppressFunc = suppressStorageDiff
 	m["storage"].ConflictsWith = []string{"catalog"}

repos/resource_repo.go

@@ -170,9 +170,7 @@ func validatePath(i interface{}, k string) (_ []string, errors []error) {
 func ResourceRepo() *schema.Resource {
 	s := common.StructToSchema(ReposInformation{}, func(s map[string]*schema.Schema) map[string]*schema.Schema {
 		s["url"].ValidateFunc = validation.IsURLWithScheme([]string{"https", "http"})
-		s["git_provider"].DiffSuppressFunc = func(k, old, new string, d *schema.ResourceData) bool {
-			return strings.EqualFold(old, new)
-		}
+		s["git_provider"].DiffSuppressFunc = common.EqualFoldDiffSuppress
 		s["branch"].ConflictsWith = []string{"tag"}
 		s["branch"].ValidateFunc = validation.StringIsNotWhiteSpace
 		s["path"].ValidateFunc = validatePath