Skip to content

Commit 644d53f

Browse files
Remove and update default params for serving (#3608)
* Remove default params for serving * remove changes for deprecated field * Update default to false * add PT acceptance test * integration test needs to be run on Unity Catalog-enabled workspace * Update to smaller model * Fix model name * Add computed and optional --------- Co-authored-by: Alex Ott <[email protected]>
1 parent 196b05b commit 644d53f

File tree

2 files changed

+38
-2
lines changed

2 files changed

+38
-2
lines changed

internal/acceptance/model_serving_test.go

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,3 +81,36 @@ func TestAccModelServing(t *testing.T) {
8181
},
8282
)
8383
}
84+
85+
func TestUcAccModelServingProvisionedThroughput(t *testing.T) {
86+
loadWorkspaceEnv(t)
87+
if isGcp(t) {
88+
skipf(t)("not available on GCP")
89+
}
90+
91+
name := fmt.Sprintf("terraform-test-model-serving-pt-%s",
92+
acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))
93+
unityWorkspaceLevel(t, step{
94+
Template: fmt.Sprintf(`
95+
resource "databricks_model_serving" "endpoint" {
96+
name = "%s"
97+
config {
98+
served_entities{
99+
name = "pt_model"
100+
entity_name = "system.ai.mistral_7b_instruct_v0_1"
101+
entity_version = "1"
102+
min_provisioned_throughput = 0
103+
max_provisioned_throughput = 970
104+
}
105+
traffic_config {
106+
routes {
107+
served_model_name = "pt_model"
108+
traffic_percentage = 100
109+
}
110+
}
111+
}
112+
}
113+
`, name),
114+
},
115+
)
116+
}

serving/resource_model_serving.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,12 @@ func ResourceModelServing() common.Resource {
3939

4040
common.MustSchemaPath(m, "config", "served_entities", "scale_to_zero_enabled").Required = false
4141
common.MustSchemaPath(m, "config", "served_entities", "scale_to_zero_enabled").Optional = true
42-
common.MustSchemaPath(m, "config", "served_entities", "scale_to_zero_enabled").Default = true
42+
common.MustSchemaPath(m, "config", "served_entities", "scale_to_zero_enabled").Default = false
4343
common.MustSchemaPath(m, "config", "served_entities", "name").Computed = true
44-
common.MustSchemaPath(m, "config", "served_entities", "workload_type").Default = "CPU"
44+
common.MustSchemaPath(m, "config", "served_entities", "workload_size").Optional = true
45+
common.MustSchemaPath(m, "config", "served_entities", "workload_size").Computed = true
46+
common.MustSchemaPath(m, "config", "served_entities", "workload_type").Optional = true
47+
common.MustSchemaPath(m, "config", "served_entities", "workload_type").Computed = true
4548
common.MustSchemaPath(m, "config", "served_entities", "workload_type").DiffSuppressFunc = func(k, old, new string, d *schema.ResourceData) bool {
4649
return old == "" && new == "CPU"
4750
}

0 commit comments

Comments
 (0)