Fix #288 - Added importers for SCIM resource (#290)

* Fix #288 - Added importers for SCIM resource

And updated documentation for all resources, making it more clear to end user.

* Fix lint

Co-authored-by: Serge Smertin <[email protected]>

Author: nfx

docs/resources/aws_s3_mount.md

@@ -1,8 +1,8 @@
 # databricks_aws_s3_mount Resource
 
-**This resource has evolving API, which may change in future versions of provider.**
+-> **Note** This resource has evolving API, which may change in future versions of provider.
 
-This resource will mount your S3 bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the cluster if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. 
+This resource will mount your S3 bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the [cluster](cluster.md) if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. 
 
 ## Example Usage
 
@@ -17,7 +17,7 @@ resource "databricks_s3_mount" "this" {
 }
 ```
 
-Full end-to-end actions required to securely mount S3 bucket on all clusters with the same instance profile:
+Full end-to-end actions required to securely mount S3 bucket on all clusters with the same [instance profile](instance_profile.md):
 
 ```hcl
 // Step 1: Create bucket
@@ -127,8 +127,8 @@ resource "databricks_s3_mount" "this" {
 
 The following arguments are required:
 
-* `cluster_id` - (Optional) (String) Cluster to use for mounting. If no cluster is specified, new cluster will be created and will mount the bucket for all of the clusters in this workspace. If cluster is specified, mount will be visible for all clusters with the same [instance profile](./instance_profile.md). If cluster is not running - it's going to be started, so be aware to set autotermination rules on it.
-* `instance_profile` - (Optional) (String) ARN of registeted instance profile for data access.
+* `cluster_id` - (Optional) (String) [Cluster](cluster.md) to use for mounting. If no cluster is specified, new cluster will be created and will mount the bucket for all of the clusters in this workspace. If cluster is specified, mount will be visible for all clusters with the same [instance profile](./instance_profile.md). If cluster is not running - it's going to be started, so be aware to set autotermination rules on it.
+* `instance_profile` - (Optional) (String) ARN of registeted [instance profile](instance_profile.md) for data access.
 * `mount_name` - (Required) (String) Name, under which mount will be accessible in `dbfs:/mnt/<MOUNT_NAME>` or locally on each instance through FUSE mount `/dbfs/mnt/<MOUNT_NAME>`.
 * `s3_bucket_name` - (Required) (String) S3 bucket name to be mounted.
 

docs/resources/azure_adls_gen1_mount.md

@@ -1,8 +1,8 @@
 # databricks_azure_adls_gen1_mount Resource
 
-**This resource has evolving API, which may change in future versions of provider.**
+-> **Note** This resource has evolving API, which may change in future versions of provider.
 
-This resource will mount your ADLS v1 bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the cluster if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. 
+This resource will mount your ADLS v1 bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the [cluster](cluster.md) if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. 
 
 
 ## Example Usage

docs/resources/azure_adls_gen2_mount.md

@@ -1,8 +1,8 @@
 # databricks_azure_adls_gen2_mount Resource
 
-**This resource has evolving API, which may change in future versions of provider.**
+-> **Note** This resource has evolving API, which may change in future versions of provider.
 
-This resource will mount your ADLS v2 bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the cluster if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. 
+This resource will mount your ADLS v2 bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the [cluster](cluster.md) if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. 
 
 ## Example Usage
 

docs/resources/azure_blob_mount.md

@@ -1,8 +1,8 @@
 # databricks_azure_blob_mount Resource
 
-**This resource has evolving API, which may change in future versions of provider.**
+-> **Note** This resource has evolving API, which may change in future versions of provider.
 
-This resource will mount your Azure Blob Storage bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the cluster if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. This resource will help you create, get and delete a azure blob storage mount using SAS token or storage account access keys.
+This resource will mount your Azure Blob Storage bucket on `dbfs:/mnt/yourname`. It is important to understand that this will start up the [cluster](cluster.md) if the cluster is terminated. The read and refresh terraform command will require a cluster and make take some time to validate mount. If cluster_id is not specified, it will create the smallest possible cluster called `terraform-mount` for shortest possible amount of time. This resource will help you create, get and delete a azure blob storage mount using SAS token or storage account access keys.
 
 
 ## Example Usage

docs/resources/cluster.md

@@ -29,7 +29,6 @@ disable automatic termination. _It is highly recommended to have this setting pr
 * `single_user_name` - (Optional) The optional user name of the user to assign to an interactive cluster. This is required when using standard AAD Passthrough for Azure Datalake Storage (ADLS) with a single-user cluster (i.e. not high-concurrency clusters).
 * `idempotency_token` - (Optional) An optional token that can be used to guarantee the idempotency of cluster creation requests. If an active cluster with the provided token already exists, the request will not create a new cluster, but it will return the ID of the existing cluster instead. The existence of a cluster with the same token is not checked against terminated clusters. If you specify the idempotency token, upon failure you can retry until the request succeeds. Databricks will guarantee that exactly one cluster will be launched with that idempotency token. This token should have at most 64 characters.
 * `ssh_public_keys` - (Optional) SSH public key contents that will be added to each Spark node in this cluster. The corresponding private keys can be used to login with the user name ubuntu on port 2200. Up to 10 keys can be specified.
-TODO: add example
 * `spark_env_vars` - (Optional) Map with environment variable key-value pairs to fine tune Spark clusters. Key-value pair of the form (X,Y) are exported as is (i.e., export X='Y') while launching the driver and workers. To specify an additional set of SPARK_DAEMON_JAVA_OPTS, we recommend appending them to $SPARK_DAEMON_JAVA_OPTS as shown in the example below. This ensures that all default databricks managed environmental variables are included as well. 
 * `custom_tags` - (Optional) Additional tags for cluster resources. Databricks will tag all cluster resources (e.g., AWS instances and EBS volumes) with these tags in addition to `default_tags`.
 * `spark_conf` - (Optional) Map with key-value pairs to fine tune Spark clusters, where you can provide custom pSpark configuration properties](https://spark.apache.org/docs/latest/configuration.html) in a cluster configuration. You can also pass in a string of extra JVM options to the driver and the executors via `spark.driver.extraJavaOptions` and `spark.executor.extraJavaOptions` respectively. It is advised to keep all common configurations in [Cluster Policies](cluster_policy.md) to maintain control of the environments launched.

docs/resources/cluster_policy.md

@@ -1,23 +1,23 @@
 # databricks_cluster_policy Resource
 
-This resource creates a cluster policy, which limits the ability to create clusters based on a set of rules. The policy rules limit the attributes or attribute values available for cluster creation. Cluster policies have ACLs that limit their use to specific users and groups. Only admin users can create, edit, and delete policies. Admin users also have access to all policies.
+This resource creates a [cluster](cluster.md) policy, which limits the ability to create clusters based on a set of rules. The policy rules limit the attributes or attribute values available for [cluster](cluster.md) creation. [cluster](cluster.md) policies have ACLs that limit their use to specific users and groups. Only admin users can create, edit, and delete policies. Admin users also have access to all policies.
 
 Cluster policies let you:
 
 * Limit users to create clusters with prescribed settings.
 * Simplify the user interface and enable more users to create their own clusters (by fixing and hiding some values).
-* Control cost by limiting per cluster maximum cost (by setting limits on attributes whose values contribute to hourly price).
+* Control cost by limiting per [cluster](cluster.md) maximum cost (by setting limits on attributes whose values contribute to hourly price).
 
 Cluster policy permissions limit which policies a user can select in the Policy drop-down when the user creates a cluster:
 
 * If no policies have been created in the workspace, the Policy drop-down does not display.
-* A user who has cluster create permission can select the Free form policy and create fully-configurable clusters.
-* A user who has both cluster create permission and access to cluster policies can select the Free form policy and policies they have access to.
-* A user that has access to only cluster policies, can select the policies they have access to.
+* A user who has [cluster](cluster.md) create permission can select the `Free form` policy and create fully-configurable clusters.
+* A user who has both [cluster](cluster.md) create permission and access to [cluster](cluster.md) policies can select the Free form policy and policies they have access to.
+* A user that has access to only [cluster](cluster.md) policies, can select the policies they have access to.
 
 ## Example Usage
 
-Let us take a look at an example of how you can manage two teams: Marketing and Data Engineering. In the following scenario we want the marketing team to have a really good query experience, so we enabled delta cache for them. On the other hand we want the data engineering team to be able to utilize bigger clusters so we increased the dbus per hour that they can spend. This strategy allows your marketing users and data engineering users to use Databricks in a self service manner but have a different experience in regards to security and performance. And down the line if you need to add more global settings you can propagate them through the “base cluster policy”.
+Let us take a look at an example of how you can manage two teams: Marketing and Data Engineering. In the following scenario we want the marketing team to have a really good query experience, so we enabled delta cache for them. On the other hand we want the data engineering team to be able to utilize bigger clusters so we increased the dbus per hour that they can spend. This strategy allows your marketing users and data engineering users to use Databricks in a self service manner but have a different experience in regards to security and performance. And down the line if you need to add more global settings you can propagate them through the “base [cluster](cluster.md) policy”.
 
 `modules/base-cluster-policy/main.tf` could look like:
 

docs/resources/group.md

@@ -1,29 +1,23 @@
 # databricks_group Resource
 
-This resource allows you to create groups in Databricks. You can also associate Databricks users to the following groups. 
-This is an alternative to `databricks_scim_group` and useful if you are using an application to sync users & groups with SCIM 
-api.
-
--> **Note** You must be a Databricks administrator API token to make SCIM api calls. 
+This resource allows you to create groups in Databricks. You can also associate Databricks users to the following groups. This is an alternative to `databricks_scim_group` and useful if you are using an application to sync users & groups with SCIM API.
 
 ## Example Usage
 
 ```hcl
 resource "databricks_group" "my_group" {
   display_name = "group_name"
-  allow_cluster_create = "true"
-  allow_instance_pool_create = "true"
+  allow_cluster_create = true
+  allow_instance_pool_create = true
 }
 ```
 ## Argument Reference
 
 The following arguments are supported:
 
-* `display_name` -  **(Required)** This is the display name for the given group.
-
-* `allow_cluster_create` -  **(Optional)** This is a field to allow the group to have cluster create priviliges.
-
-* `allow_instance_pool_create` -  **(Optional)** This is a field to allow the group to have instance pool create priviliges.
+* `display_name` -  (Required) This is the display name for the given group.
+* `allow_cluster_create` -  (Optional) This is a field to allow the group to have [cluster](cluster.md) create priviliges.
+* `allow_instance_pool_create` -  (Optional) This is a field to allow the group to have [instance pool](instance_pool.md) create priviliges.
 
 ## Attribute Reference
 

docs/resources/group_instance_profile.md

@@ -1,12 +1,10 @@
 # databricks_group_instance_profile Resource
 
-**This resource has evolving API, which may change in future versions of provider.**
+-> **Note** This resource has evolving API, which may change in future versions of provider.
 
-This resource allows you to attach instance profiles to groups created by the `databricks_group` resource.
+This resource allows you to attach instance profiles to groups created by the [group](group.md) resource.
 
--> **Note** Please only use this resource in conjunction with the `databricks_group` resource and **not** the `databricks_scim_group` resource.
-
--> **Note** You must be a Databricks administrator API token to make SCIM api calls. 
+-> **Note** Please only use this resource in conjunction with the [group](group.md) resource and **not** the `databricks_scim_group` resource.
 
 ## Example Usage
 
@@ -27,15 +25,14 @@ resource "databricks_group_instance_profile" "my_group_instance_profile" {
 
 The following arguments are supported:
 
-* `group_id` - **(Required)** This is the id of the `databricks_group` resource.
-
-* `instance_profile_id` -  **(Required)** This is the id of the `databricks_instance_profile` resource.
+* `group_id` - (Required) This is the id of the [group](group.md) resource.
+* `instance_profile_id` -  (Required) This is the id of the [instance profile](instance_profile.md) resource.
 
 ## Attribute Reference
 
 In addition to all arguments above, the following attributes are exported:
 
-*  `id` - The id for the `databricks_group_instance_profile` object which is in the format `<group_id>|<instance_profile_id>`.
+*  `id` - The id for the [instance profile](instance_profile.md) object which is in the format `<group_id>|<instance_profile_id>`.
 
 ## Import
 

docs/resources/group_member.md

@@ -1,10 +1,8 @@
 # databricks_group_member Resource
 
-This resource allows you to attach members to groups created by the `databricks_group` resource.
+This resource allows you to attach members to groups created by the [group](group.md) resource.
 
--> **Note** Please only use this resource in conjunction with the `databricks_group` resource and **not** the `databricks_scim_group` resource.
- 
--> **Note** You must be a Databricks administrator API token to make SCIM api calls. 
+-> **Note** Please only use this resource in conjunction with the [group](group.md) resource and **not** the `databricks_scim_group` resource.
 
 ## Example Usage
 
@@ -31,9 +29,8 @@ resource "databricks_group_member" "my_member_b" {
 
 The following arguments are supported:
 
-* `group_id` - **(Required)** This is the id of the `databricks_group` resource.
-
-* `member_id` - **(Required)** This is the id of the `databricks_group` or `databricks_scim_user` resource. 
+* `group_id` - (Required) This is the id of the [group](group.md) resource.
+* `member_id` - (Required) This is the id of the [group](group.md) or `databricks_scim_user` resource. 
 >Members can be groups or users created by the scim api.
 
 ## Attribute Reference