Add terraform support for Job Parameters (Private Preview) (#2509)

* start

* Add JobParameters to Terraform

* fmt fix

* revert scim changes

* Rename variables

* nit

* add documentation

* naming nits

* add alias and change documentation

* add test coverage

* add run-now tests

* add passing tests

* lint fix

Author: geekswaroop

docs/resources/job.md

@@ -239,6 +239,13 @@ This block controls notification settings for both email & webhook notifications
 * `no_alert_for_skipped_runs` - (Optional) (Bool) don't send alert for skipped runs.
 * `no_alert_for_canceled_runs` - (Optional) (Bool) don't send alert for cancelled runs.
 
+###  parameter Configuration Block
+
+This block defines a job-level parameter for the job. You can define several job-level parameters for the job. Supported options are:
+
+* `name` - (Required) The name of the defined parameter. May only contain alphanumeric characters, `_`, `-`, and `.`.
+* `default` - (Required) Default value of the parameter.
+
 ###  notification_settings Configuration Block (Task Level)
 
 This block controls notification settings for both email & webhook notifications on a task level:

jobs/resource_job.go

@@ -294,6 +294,7 @@ type JobSettings struct {
 	Queue                *Queue                        `json:"queue,omitempty"`
 	RunAs                *JobRunAs                     `json:"run_as,omitempty"`
 	Health               *JobHealth                    `json:"health,omitempty"`
+	Parameters           []JobParameterDefinition      `json:"parameters,omitempty" tf:"alias:parameter"`
 }
 
 func (js *JobSettings) isMultiTask() bool {
@@ -341,6 +342,19 @@ type RunParameters struct {
 	SparkSubmitParams []string          `json:"spark_submit_params,omitempty"`
 }
 
+// Job-level parameter
+type JobParameter struct {
+	Name    string `json:"name,omitempty"`
+	Default string `json:"default,omitempty"`
+	Value   string `json:"value,omitempty"`
+}
+
+// Job-level parameter definitions
+type JobParameterDefinition struct {
+	Name    string `json:"name,omitempty"`
+	Default string `json:"default,omitempty"`
+}
+
 // RunState of the job
 type RunState struct {
 	ResultState    string `json:"result_state,omitempty"`
@@ -358,7 +372,8 @@ type JobRun struct {
 	Trigger     string   `json:"trigger,omitempty"`
 	RuntType    string   `json:"run_type,omitempty"`
 
-	OverridingParameters RunParameters `json:"overriding_parameters,omitempty"`
+	OverridingParameters RunParameters  `json:"overriding_parameters,omitempty"`
+	JobParameters        []JobParameter `json:"job_parameters,omitempty"`
 }
 
 // JobRunsListRequest used to do what it sounds like

jobs/resource_job_test.go

@@ -269,6 +269,91 @@ func TestResourceJobCreate_MultiTask(t *testing.T) {
 	assert.Equal(t, "789", d.Id())
 }
 
+func TestResourceJobCreate_JobParameters(t *testing.T) {
+	d, err := qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "POST",
+				Resource: "/api/2.1/jobs/create",
+				ExpectedRequest: JobSettings{
+					Name: "JobParameterTesting",
+					Tasks: []JobTaskSettings{
+						{
+							TaskKey: "a",
+						},
+						{
+							TaskKey: "b",
+						},
+					},
+					MaxConcurrentRuns: 1,
+					Parameters: []JobParameterDefinition{
+						{
+							Name:    "hello",
+							Default: "world",
+						},
+						{
+							Name:    "key",
+							Default: "value_default",
+						},
+					},
+				},
+				Response: Job{
+					JobID: 231,
+				},
+			},
+			{
+				Method:   "GET",
+				Resource: "/api/2.1/jobs/get?job_id=231",
+				Response: Job{
+					// good enough for mock
+					Settings: &JobSettings{
+						Tasks: []JobTaskSettings{
+							{
+								TaskKey: "a",
+							},
+							{
+								TaskKey: "b",
+							},
+						},
+						Parameters: []JobParameterDefinition{
+							{
+								Name:    "hello",
+								Default: "world",
+							},
+							{
+								Name:    "key",
+								Default: "value_default",
+							},
+						},
+					},
+				},
+			},
+		},
+		Create:   true,
+		Resource: ResourceJob(),
+		HCL: `
+		name = "JobParameterTesting"
+
+		parameter {
+				name = "hello"
+				default = "world"
+		}
+		parameter {
+				name = "key"
+				default = "value_default"
+		}
+	
+		task {
+			task_key = "a"
+		}
+
+		task {
+			task_key = "b"
+		}`,
+	}.Apply(t)
+	assert.NoError(t, err)
+	assert.Equal(t, "231", d.Id())
+}
 func TestResourceJobCreate_JobClusters(t *testing.T) {
 	d, err := qa.ResourceFixture{
 		Fixtures: []qa.HTTPFixture{