Release v0.5.3 (#1189)

Author: nfx

README.md

@@ -82,7 +82,7 @@ terraform {
   required_providers {
     databricks = {
       source  = "databrickslabs/databricks"
-      version = "0.5.2"
+      version = "0.5.3"
     }
   }
 }

catalog/resource_grants_test.go

@@ -168,22 +168,22 @@ func TestPermissionsList_Diff_ExternallyAddedPrincipal(t *testing.T) {
 	diff := PermissionsList{ // config
 		Assignments: []PrivilegeAssignment{
 			{
-				Principal: "a",
+				Principal:  "a",
 				Privileges: []string{"a"},
 			},
 			{
-				Principal: "c",
+				Principal:  "c",
 				Privileges: []string{"a"},
 			},
 		},
 	}.diff(PermissionsList{
 		Assignments: []PrivilegeAssignment{ // platform
 			{
-				Principal: "a",
+				Principal:  "a",
 				Privileges: []string{"a"},
 			},
 			{
-				Principal: "b",
+				Principal:  "b",
 				Privileges: []string{"a"},
 			},
 		},
@@ -200,14 +200,14 @@ func TestPermissionsList_Diff_ExternallyAddedPriv(t *testing.T) {
 	diff := PermissionsList{ // config
 		Assignments: []PrivilegeAssignment{
 			{
-				Principal: "a",
+				Principal:  "a",
 				Privileges: []string{"a"},
 			},
 		},
 	}.diff(PermissionsList{
 		Assignments: []PrivilegeAssignment{ // platform
 			{
-				Principal: "a",
+				Principal:  "a",
 				Privileges: []string{"a", "b"},
 			},
 		},
@@ -222,14 +222,14 @@ func TestPermissionsList_Diff_LocalRemoteDiff(t *testing.T) {
 	diff := PermissionsList{ // config
 		Assignments: []PrivilegeAssignment{
 			{
-				Principal: "a",
+				Principal:  "a",
 				Privileges: []string{"a", "b"},
 			},
 		},
 	}.diff(PermissionsList{
 		Assignments: []PrivilegeAssignment{ // platform
 			{
-				Principal: "a",
+				Principal:  "a",
 				Privileges: []string{"b", "c"},
 			},
 		},
@@ -239,4 +239,4 @@ func TestPermissionsList_Diff_LocalRemoteDiff(t *testing.T) {
 	assert.Len(t, diff.Changes[0].Remove, 1)
 	assert.Equal(t, "a", diff.Changes[0].Add[0])
 	assert.Equal(t, "c", diff.Changes[0].Remove[0])
-}
+}

clusters/clusters_api.go

@@ -613,7 +613,7 @@ func wrapMissingClusterError(err error, id string) error {
 		return err
 	}
 	// https://github.com/databrickslabs/terraform-provider-databricks/issues/1177
-	// Aligned with Clusters Core team to keep behavior of these workarounds 
+	// Aligned with Clusters Core team to keep behavior of these workarounds
 	// as is in the longer term, so that this keeps working.
 	if apiErr.ErrorCode == "INVALID_STATE" {
 		log.Printf("[WARN] assuming that cluster is removed on backend: %s", apiErr)

clusters/clusters_api_test.go

@@ -1206,7 +1206,7 @@ func TestWrapMissingClusterError(t *testing.T) {
 func TestExpiredClusterAssumedAsRemoved(t *testing.T) {
 	err := wrapMissingClusterError(common.APIError{
 		ErrorCode: "INVALID_STATE",
-		Message: "Cannot access cluster X that was terminated or unpinned more than Y days ago.",
+		Message:   "Cannot access cluster X that was terminated or unpinned more than Y days ago.",
 	}, "X")
 	ae, _ := err.(common.APIError)
 	assert.Equal(t, 404, ae.StatusCode)

docs/guides/unity-catalog-azure.md

@@ -41,7 +41,7 @@ locals {
   databricks_workspace_name = regex(local.resource_regex, var.databricks_resource_id)[2]
   tenant_id                 = data.azurerm_client_config.current.tenant_id
   databricks_workspace_host = data.azurerm_databricks_workspace.this.workspace_url
-  databricks_workspace_id    = data.azurerm_databricks_workspace.this.workspace_id
+  databricks_workspace_id   = data.azurerm_databricks_workspace.this.workspace_id
   prefix                    = replace(replace(lower(data.azurerm_resource_group.this.name), "rg", ""), "-", "")
 }
 
@@ -70,8 +70,7 @@ terraform {
       version = "~>2.19.0"
     }
     databricks = {
-      source  = "databrickslabs/databricks"
-      version = "~>0.5.2"
+      source = "databrickslabs/databricks"
     }
   }
 }
@@ -138,7 +137,7 @@ A [databricks_metastore](../resources/metastore.md) is the top level container f
 
 ```hcl
 resource "databricks_metastore" "this" {
-  name         = "primary"
+  name = "primary"
   storage_root = format("abfss://%s@%s.dfs.core.windows.net/",
     azurerm_storage_account.unity_catalog.name,
   azurerm_storage_container.unity_catalog.name)
@@ -180,7 +179,7 @@ resource "databricks_catalog" "sandbox" {
 }
 
 resource "databricks_grants" "sandbox" {
-  catalog  = databricks_catalog.sandbox.name
+  catalog = databricks_catalog.sandbox.name
   grant {
     principal  = "Data Scientists"
     privileges = ["USAGE", "CREATE"]
@@ -201,7 +200,7 @@ resource "databricks_schema" "things" {
 }
 
 resource "databricks_grants" "things" {
-  schema   = databricks_schema.things.id
+  schema = databricks_schema.things.id
   grant {
     principal  = "Data Engineers"
     privileges = ["USAGE"]
@@ -267,7 +266,7 @@ resource "databricks_storage_credential" "external" {
   comment = "Managed by TF"
   depends_on = [
     databricks_metastore_assignment.this
-  ]  
+  ]
 }
 
 resource "databricks_grants" "external_creds" {
@@ -326,7 +325,7 @@ resource "databricks_cluster" "unity_sql" {
   # need to wait until the metastore is assigned
   depends_on = [
     databricks_metastore_assignment.this
-  ]    
+  ]
 }
 ```
 
@@ -365,7 +364,7 @@ resource "databricks_cluster" "dev" {
   # need to wait until the metastore is assigned
   depends_on = [
     databricks_metastore_assignment.this
-  ]    
+  ]
 }
 
 resource "databricks_permissions" "dev_restart" {

docs/guides/unity-catalog-aws.md renamed to docs/guides/unity-catalog.md

@@ -338,7 +338,7 @@ terraform {
   required_providers {
     databricks = {
       source  = "databrickslabs/databricks"
-      version = "0.5.2"
+      version = "0.5.3"
     }
   }
 }

docs/index.md

@@ -51,7 +51,7 @@ resource "databricks_storage_credential" "external" {
   comment = "Managed by TF"
   depends_on = [
     databricks_metastore_assignment.this
-  ]  
+  ]
 }
 
 resource "databricks_external_location" "some" {

docs/resources/external_location.md

@@ -31,7 +31,7 @@ For Azure
 
 ```hcl
 resource "databricks_metastore" "this" {
-  name          = "primary"
+  name = "primary"
   storage_root = format("abfss://%s@%s.dfs.core.windows.net/",
     azurerm_storage_account.unity_catalog.name,
   azurerm_storage_container.unity_catalog.name)

docs/resources/metastore.md

@@ -33,7 +33,7 @@ For Azure
 
 ```hcl
 resource "databricks_metastore" "this" {
-  name          = "primary"
+  name = "primary"
   storage_root = format("abfss://%s@%s.dfs.core.windows.net/",
     azurerm_storage_account.unity_catalog.name,
   azurerm_storage_container.unity_catalog.name)