Deprecate top level task attributes (#2993)

* Deprecate `max_retries` and `retry_on_timeout` on job level

* Deprecate top level task attributes and `min_retry_interval_millis`

* Use loop instead

* rename variable

* Write a deprecation notice for single-task syntax

Author: 840

docs/resources/job.md

@@ -419,7 +419,9 @@ By default, all users can create and modify jobs unless an administrator [enable
 * [databricks_permissions](permissions.md#Job-usage) can control which groups or individual users can *Can View*, *Can Manage Run*, and *Can Manage*.
 * [databricks_cluster_policy](cluster_policy.md) can control which kinds of clusters users can create for jobs.
 
-## Single-task syntax (legacy)
+## Single-task syntax (deprecated)
+
+-> **Deprecated** Please define tasks in a `task` block rather than using single-task syntax. 
 
 This syntax uses Jobs API 2.0 to create a job with a single task. Only a subset of arguments above is supported (`name`, `libraries`, `email_notifications`, `webhook_notifications`, `timeout_seconds`, `max_retries`, `min_retry_interval_millis`, `retry_on_timeout`, `schedule`, `max_concurrent_runs`), and only a single block of `notebook_task`, `spark_jar_task`, `spark_python_task`, `spark_submit_task` and `pipeline_task` can be specified.
 

jobs/resource_job.go

@@ -687,6 +687,25 @@ var jobSchema = common.StructToSchema(JobSettings{},
 		s["continuous"].ConflictsWith = []string{"schedule", "trigger"}
 		s["trigger"].ConflictsWith = []string{"schedule", "continuous"}
 
+		// Deprecated Job API 2.0 attributes
+		var topLevelDeprecatedAttr = []string{
+			"max_retries",
+			"min_retry_interval_millis",
+			"retry_on_timeout",
+			"notebook_task",
+			"spark_jar_task",
+			"spark_python_task",
+			"spark_submit_task",
+			"pipeline_task",
+			"python_wheel_task",
+			"dbt_task",
+			"run_job_task",
+		}
+
+		for _, attr := range topLevelDeprecatedAttr {
+			s[attr].Deprecated = "should be used inside a task block and not inside a job block"
+		}
+
 		// we need to have only one of user name vs service principal in the run_as block
 		run_as_eoo := []string{"run_as.0.user_name", "run_as.0.service_principal_name"}
 		common.MustSchemaPath(s, "run_as", "user_name").ExactlyOneOf = run_as_eoo