Fixed databricks_permissions resource for correct permissions update. (#2719)

* bug

* -

* -

* bug

* bug

Author: tanmay-db

permissions/resource_permissions.go

@@ -175,7 +175,7 @@ func (a PermissionsAPI) Update(objectID string, objectACL AccessControlChangeLis
 			PermissionLevel: "CAN_MANAGE",
 		})
 	}
-	if strings.HasPrefix(objectID, "/jobs") || strings.HasPrefix(objectID, "/pipelines") || strings.HasPrefix(objectID, "/sql/warehouses") {
+	if strings.HasPrefix(objectID, "/jobs") || strings.HasPrefix(objectID, "/pipelines") {
 		owners := 0
 		for _, acl := range objectACL.AccessControlList {
 			if acl.PermissionLevel == "IS_OWNER" {
@@ -245,15 +245,6 @@ func (a PermissionsAPI) Delete(objectID string) error {
 			UserName:        job.CreatorUserName,
 			PermissionLevel: "IS_OWNER",
 		})
-	} else if strings.HasPrefix(objectID, "/sql/warehouses") {
-		warehouse, err := w.Warehouses.GetById(a.context, strings.ReplaceAll(objectID, "/sql/warehouses", ""))
-		if err != nil {
-			return err
-		}
-		accl.AccessControlList = append(accl.AccessControlList, AccessControlChange{
-			UserName:        warehouse.CreatorName,
-			PermissionLevel: "IS_OWNER",
-		})
 	}
 	return a.put(objectID, accl)
 }

permissions/resource_permissions_test.go

@@ -23,6 +23,7 @@ import (
 var (
 	TestingUser      = "ben"
 	TestingAdminUser = "admin"
+	TestingOwner     = "testOwner"
 	me               = qa.HTTPFixture{
 		ReuseRequest: true,
 		Method:       "GET",
@@ -825,8 +826,67 @@ func TestResourcePermissionsCreate_SQLA_Endpoint(t *testing.T) {
 						},
 						{
 							UserName:        TestingAdminUser,
+							PermissionLevel: "CAN_MANAGE",
+						},
+					},
+				},
+			},
+			{
+				Method:   http.MethodGet,
+				Resource: "/api/2.0/permissions/sql/warehouses/abc",
+				Response: ObjectACL{
+					ObjectID:   "/sql/dashboards/abc",
+					ObjectType: "dashboard",
+					AccessControlList: []AccessControl{
+						{
+							UserName:        TestingUser,
+							PermissionLevel: "CAN_USE",
+						},
+						{
+							UserName:        TestingAdminUser,
+							PermissionLevel: "CAN_MANAGE",
+						},
+					},
+				},
+			},
+		},
+		Resource: ResourcePermissions(),
+		State: map[string]any{
+			"sql_endpoint_id": "abc",
+			"access_control": []any{
+				map[string]any{
+					"user_name":        TestingUser,
+					"permission_level": "CAN_USE",
+				},
+			},
+		},
+		Create: true,
+	}.Apply(t)
+	assert.NoError(t, err)
+	ac := d.Get("access_control").(*schema.Set)
+	require.Equal(t, 1, len(ac.List()))
+	firstElem := ac.List()[0].(map[string]any)
+	assert.Equal(t, TestingUser, firstElem["user_name"])
+	assert.Equal(t, "CAN_USE", firstElem["permission_level"])
+}
+
+func TestResourcePermissionsCreate_SQLA_Endpoint_WithOwner(t *testing.T) {
+	d, err := qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			me,
+			{
+				Method:   "PUT",
+				Resource: "/api/2.0/permissions/sql/warehouses/abc",
+				ExpectedRequest: AccessControlChangeList{
+					AccessControlList: []AccessControlChange{
+						{
+							UserName:        TestingOwner,
 							PermissionLevel: "IS_OWNER",
 						},
+						{
+							UserName:        TestingUser,
+							PermissionLevel: "CAN_USE",
+						},
 						{
 							UserName:        TestingAdminUser,
 							PermissionLevel: "CAN_MANAGE",
@@ -850,7 +910,7 @@ func TestResourcePermissionsCreate_SQLA_Endpoint(t *testing.T) {
 							PermissionLevel: "CAN_MANAGE",
 						},
 						{
-							UserName:        TestingAdminUser,
+							UserName:        TestingOwner,
 							PermissionLevel: "IS_OWNER",
 						},
 					},
@@ -865,16 +925,39 @@ func TestResourcePermissionsCreate_SQLA_Endpoint(t *testing.T) {
 					"user_name":        TestingUser,
 					"permission_level": "CAN_USE",
 				},
+				map[string]any{
+					"user_name":        TestingOwner,
+					"permission_level": "IS_OWNER",
+				},
 			},
 		},
 		Create: true,
 	}.Apply(t)
 	assert.NoError(t, err)
 	ac := d.Get("access_control").(*schema.Set)
-	require.Equal(t, 1, len(ac.List()))
-	firstElem := ac.List()[0].(map[string]any)
-	assert.Equal(t, TestingUser, firstElem["user_name"])
-	assert.Equal(t, "CAN_USE", firstElem["permission_level"])
+	accessControlList := ac.List()
+	require.Equal(t, 2, len(accessControlList))
+	foundTestingUser := false
+	foundTestingOwner := false
+
+	for _, entry := range accessControlList {
+		entryMap, ok := entry.(map[string]any)
+		if !ok {
+			t.Fatalf("Expected the entry to be of type map[string]any, got %T", entry)
+		}
+		if userName, exists := entryMap["user_name"].(string); exists {
+			switch userName {
+			case TestingUser:
+				foundTestingUser = true
+				assert.Equal(t, "CAN_USE", entryMap["permission_level"], "Permission level for TestingUser is not CAN_USE")
+			case TestingOwner:
+				foundTestingOwner = true
+				assert.Equal(t, "IS_OWNER", entryMap["permission_level"], "Permission level for TestingOwner is not IS_OWNER")
+			}
+		}
+	}
+	assert.True(t, foundTestingUser)
+	assert.True(t, foundTestingOwner)
 }
 
 func TestResourcePermissionsCreate_NotebookPath_NotExists(t *testing.T) {