Delete automatically created visualization for new queries

Author: pietern

sqlanalytics/resource_query.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"log"
 	"reflect"
+	"strconv"
 	"strings"
 
 	"github.com/databrickslabs/terraform-provider-databricks/common"
@@ -449,11 +450,11 @@ func (a QueryAPI) Create(q *api.Query) error {
 		if err != nil {
 			return err
 		}
-		// TODO
-		// err = a.DeleteVisualization(&v)
-		// if err != nil {
-		// 	return nil, err
-		// }
+		// This is a best effort -- don't fail if it doesn't work.
+		err = NewVisualizationAPI(a.context, a.client).Delete(strconv.Itoa(v.ID))
+		if err != nil {
+			log.Printf("[WARN] Unable to delete automatically created visualization for query %s (%d)", q.ID, v.ID)
+		}
 	}
 	q.Visualizations = []json.RawMessage{}
 	return nil

sqlanalytics/resource_query_test.go

@@ -1,6 +1,7 @@
 package sqlanalytics
 
 import (
+	"encoding/json"
 	"testing"
 
 	"github.com/databrickslabs/terraform-provider-databricks/qa"
@@ -281,6 +282,60 @@ func TestQueryCreateWithWeeklySchedule(t *testing.T) {
 	assert.Equal(t, untilDate, d.Get("schedule.0.weekly.0.until_date"))
 }
 
+func TestQueryCreateDeletesDefaultVisualization(t *testing.T) {
+	_, err := qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "POST",
+				Resource: "/api/2.0/preview/sql/queries",
+				ExpectedRequest: api.Query{
+					DataSourceID: "xyz",
+					Name:         "Query name",
+					Query:        "SELECT 1",
+				},
+				Response: api.Query{
+					ID:           "foo",
+					DataSourceID: "xyz",
+					Name:         "Query name",
+					Query:        "SELECT 1",
+
+					// The automatically created visualization should be deleted.
+					Visualizations: []json.RawMessage{
+						json.RawMessage(`
+							{
+								"id": 12345
+							}
+						`),
+					},
+				},
+			},
+			{
+				Method:   "GET",
+				Resource: "/api/2.0/preview/sql/queries/foo",
+				Response: api.Query{
+					ID:           "foo",
+					DataSourceID: "xyz",
+					Name:         "Query name",
+					Query:        "SELECT 1",
+				},
+			},
+			{
+				Method:   "DELETE",
+				Resource: "/api/2.0/preview/sql/visualizations/12345",
+			},
+		},
+		Resource: ResourceQuery(),
+		Create:   true,
+		State: map[string]interface{}{
+			"data_source_id": "xyz",
+			"name":           "Query name",
+			"query":          "SELECT 1",
+		},
+	}.Apply(t)
+
+	assert.NoError(t, err, err)
+}
+
 func TestQueryRead(t *testing.T) {
 	d, err := qa.ResourceFixture{
 		Fixtures: []qa.HTTPFixture{